Issue 405403002: Close FileOutputStream in finally block in WebAppAuthenticator class method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405403002: Close FileOutputStream in finally block in WebAppAuthenticator class method. (Closed)

Created:
6 years, 5 months ago by wajahat

Modified:
6 years, 5 months ago

Reviewers:
palmer, David Trainor- moved to gerrit, Yaron

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Close FileOutputStream in finally block in WebAppAuthenticator class method. FileOutStream should be closed in finally block in writeKeyToFile() method, as closing in try{} will not close and release system resources when an exeption is thrown. Also, catch relavant exception instead of catching generic exception. BUG=None. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284735

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/WebappAuthenticator.java	View		3 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wajahat.s@samsung.com/405403002/1

6 years, 5 months ago (2014-07-22 16:16:22 UTC) #4

Message was sent while issue was closed.

Change committed as 284735

Expand Messages | Collapse Messages