Add landmines support.

Add landmines support.

The scripts are copied from chromium/src/build and simplified.

BUG=
R=jkummerow@chromium.org, jochen@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22529

[Michael Achenbach, 2014-07-22 14:04:45]

PTAL

https://codereview.chromium.org/405373005/diff/1/build/get_landmines.py
File build/get_landmines.py (right):

https://codereview.chromium.org/405373005/diff/1/build/get_landmines.py#newco...
build/get_landmines.py:15: def main():
Simplified. Can only emit global landmines. Independent of platform, target,
etc.

https://codereview.chromium.org/405373005/diff/1/build/landmines.py
File build/landmines.py (right):

https://codereview.chromium.org/405373005/diff/1/build/landmines.py#newcode61
build/landmines.py:61: if not os.path.exists(out_dir):
The original script creates the dir here. I wonder why. I'd assume the dir
exists if I want to clobber it.

https://codereview.chromium.org/405373005/diff/1/build/landmines.py#newcode120
build/landmines.py:120: for s in landmine_scripts:
I simplified this compared to the original script and removed target-specific
landmine support.

[Michael Achenbach, 2014-07-22 14:11:54]

Ah, actually, the git/svn ignore is not necessary as the files are withing
build/out/xcodebuild which is of course already ignored.

[Michael Achenbach, 2014-07-22 14:19:00]

Patch 3 adds part of the landmine_utils to calculate the build dir.

[Michael Achenbach, 2014-07-22 14:25:53]

OK - the trybot likes me now. Can this be landed?

[Jakob Kummerow, 2014-07-22 14:51:45]

Seems like a lot of complexity just to clobber the bots now and then... but at
least it's not written from scratch.

LGTM.

[jochen (gone - plz use gerrit), 2014-07-22 14:52:05]

lgtm with nits

https://codereview.chromium.org/405373005/diff/60001/build/get_landmines.py
File build/get_landmines.py (right):

https://codereview.chromium.org/405373005/diff/60001/build/get_landmines.py#n...
build/get_landmines.py:3: # Copyright 2013 The Chromium Authors. All rights
reserved.
for other files we imported, we just stripped this part

https://codereview.chromium.org/405373005/diff/60001/build/get_landmines.py#n...
build/get_landmines.py:20: # if builder() == 'make':
if you want to use builder, you also need to import the utils

https://codereview.chromium.org/405373005/diff/60001/build/landmine_utils.py
File build/landmine_utils.py (right):

https://codereview.chromium.org/405373005/diff/60001/build/landmine_utils.py#...
build/landmine_utils.py:105: return 'ninja'
we use make, no?

https://codereview.chromium.org/405373005/diff/60001/build/landmine_utils.py#...
build/landmine_utils.py:109: return 'ninja'
and msvs

https://codereview.chromium.org/405373005/diff/60001/build/landmine_utils.py#...
build/landmine_utils.py:111: return 'ninja'
and make here

https://codereview.chromium.org/405373005/diff/60001/build/landmine_utils.py#...
build/landmine_utils.py:113: return 'ninja'
and xcode there

[Michael Achenbach, 2014-07-22 15:03:59]

All done.

https://codereview.chromium.org/405373005/diff/60001/build/landmine_utils.py
File build/landmine_utils.py (right):

https://codereview.chromium.org/405373005/diff/60001/build/landmine_utils.py#...
build/landmine_utils.py:105: return 'ninja'
On 2014/07/22 14:52:05, jochen wrote:
> we use make, no?

Right. I relied on GYP_GENERATORS - but it is actually not set.

[Michael Achenbach, 2014-07-22 15:06:28]

Committed patchset #5 manually as r22529 (tree was closed).