Issue 405373002: Use a correct scale factor in app_list::CachedLabel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405373002: Use a correct scale factor in app_list::CachedLabel (Closed)

Created:
6 years, 5 months ago by tapted

Modified:
6 years, 5 months ago

Reviewers:
calamity

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use a correct scale factor in app_list::CachedLabel It currently just uses 1.0. Instead, fetch it with ui::GetScaleFactorForNativeView and invalidate it when the scale factor changes. This is a small fix for a simple HiDPI bug, but eventually we will be able to scrap CachedLabel: The performance improvement it offers will be redundant with http://crbug.com/240037. BUG=368493 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284649

Patch Set 1 #

Patch Set 2 : call parent #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	ui/app_list/views/cached_label.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	ui/app_list/views/cached_label.cc	View	1	3 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/405373002/20001

6 years, 5 months ago (2014-07-22 07:44:53 UTC) #4

Message was sent while issue was closed.

Change committed as 284649

Expand Messages | Collapse Messages