Issue 405343002: X87: Introduce FLAG_vector_ics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405343002: X87: Introduce FLAG_vector_ics. (Closed)

Created:
6 years, 5 months ago by chunyang.dai

Modified:
6 years, 5 months ago

Reviewers:
Weiliang, mvstanton

CC:
v8-dev, danno

Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

X87: Introduce FLAG_vector_ics. port r22500. original commit message: Introduce FLAG_vector_ics. When FLAG_vector_ics is true, then AST nodes that use Load and KeyedLoad ICs will allocate a type vector slot to store feedback information. Full codegen will emit a load of the slot into a register if the flag is on. Support is incomplete, right now the IC doesn't know how to use the feedback slot. BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22542

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+129 lines, -20 lines)			Patch
M	src/x87/builtins-x87.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x87/full-codegen-x87.cc	View	14 chunks	+54 lines, -10 lines	0 comments	Download
M	src/x87/ic-x87.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/x87/lithium-codegen-x87.cc	View	3 chunks	+28 lines, -0 lines	0 comments	Download
M	src/x87/lithium-x87.h	View	3 chunks	+15 lines, -6 lines	0 comments	Download
M	src/x87/lithium-x87.cc	View	3 chunks	+17 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

chunyang.dai

Hello, Danno & Mvstanton. Could you please help to review and commit this porting patch? ...

6 years, 5 months ago (2014-07-23 02:11:47 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r22542.

Expand Messages | Collapse Messages