Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 40533003: Fix the output of "gn args" for the OS and CPU architecture. (Closed)

Created:
7 years, 2 months ago by brettw
Modified:
7 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Fix the output of "gn args" for the OS and CPU architecture. The internal declarations of these weren't getting set correctly. This only affects the output of "gn args". BUG= R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M tools/gn/args.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M tools/gn/secondary/build/config/BUILDCONFIG.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
7 years, 2 months ago (2013-10-24 17:58:45 UTC) #1
Nico
lgtm I guess :-) Test?
7 years, 2 months ago (2013-10-24 17:59:52 UTC) #2
brettw
There is some stuff in the "args" command that should have tests, but I don't ...
7 years, 2 months ago (2013-10-24 20:47:00 UTC) #3
Nico
If it's worth fixing, it's worth testing *shrug* On Thu, Oct 24, 2013 at 1:47 ...
7 years, 2 months ago (2013-10-24 20:48:29 UTC) #4
brettw
7 years, 1 month ago (2013-10-25 22:23:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r231134 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698