Chromium Code Reviews
Help | Chromium Project | Sign in
(465)

Issue 4053006: Fix remoting to use scoped_refptr. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by willchan
Modified:
2 years, 11 months ago
Reviewers:
Nico, awong
CC:
chromium-reviews_chromium.org, Sergey Ulanov, dmac, awong, garykac, Alpha
Visibility:
Public.

Description

Fix remoting to use scoped_refptr.

BUG=28083
TEST=existing

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63603

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Lint Patch
M remoting/client/plugin/pepper_view.cc View 1 chunk +3 lines, -3 lines 1 comment ? errors Download
Commit:

Messages

Total messages: 4
willchan
3 years, 6 months ago #1
awong
LGTM On Fri, Oct 22, 2010 at 4:46 PM, <willchan@chromium.org> wrote: > Reviewers: awong, > ...
3 years, 6 months ago #2
Nico
drive-by question http://codereview.chromium.org/4053006/diff/1/2 File remoting/client/plugin/pepper_view.cc (right): http://codereview.chromium.org/4053006/diff/1/2#newcode224 remoting/client/plugin/pepper_view.cc:224: NewTracedMethod(this, &PepperView::OnPartialFrameOutput, Hi Will, OnPartialFrameOutput takes a ...
3 years, 6 months ago #3
willchan
3 years, 6 months ago #4
On Sun, Oct 24, 2010 at 12:51 PM, <thakis@chromium.org> wrote:

> drive-by question
>
>
> http://codereview.chromium.org/4053006/diff/1/2
> File remoting/client/plugin/pepper_view.cc (right):
>
> http://codereview.chromium.org/4053006/diff/1/2#newcode224
> remoting/client/plugin/pepper_view.cc:224: NewTracedMethod(this,
> &PepperView::OnPartialFrameOutput,
> Hi Will,
>
> OnPartialFrameOutput takes a raw |frame| pointer, not a scoped_refptr.
> The bug is only about adding make_scoped_refptr if the function does
> take a scoped_refptr. Should OnPartialFrameOutput's parameter be made a
> scoped_refptr?
>
> Nico


Without going into too much detail (read the bug thread for more), this is
not important.  What's important is what is passed into NewRunnableMethod()
and friends, since that will decide the Tuple type created for the Params.
 And we need the Tuple to have a scoped_refptr instead of a raw pointer.
 The function prototype doesn't matter.  The Tuple will only be deleted
after Task::Run() is invoked, so the lifetime is guaranteed during the
method invocation.


>
>
> http://codereview.chromium.org/4053006/show
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6