Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 405263002: Base new scale on minimum-scale after orientation change. (Closed)

Created:
6 years, 5 months ago by aelias_OOO_until_Jul13
Modified:
6 years, 5 months ago
Reviewers:
jdduke (slow)
CC:
blink-reviews, Kyungtae Kim, trchen
Project:
blink
Visibility:
Public.

Description

Base new scale on minimum-scale after orientation change. The previous width-ratio based logic was complicated, and behaves badly in a particular scenario where the contents overflows past the webmaster's specified minimum scale. Replace it with some much simpler logic that just maintains distance from minimum scale. (In most cases this behaves the same as before, because minimum scale is usually based on the ratio of viewport width to contents width.) NOTRY=true BUG=395503 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178608

Patch Set 1 #

Patch Set 2 : Update unit test comment #

Patch Set 3 : Bring back contentsSize != 0 check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -19 lines) Patch
M Source/web/WebViewImpl.cpp View 1 2 2 chunks +7 lines, -19 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 1 chunk +16 lines, -0 lines 0 comments Download
A Source/web/tests/data/resize_scroll_minimum_scale.html View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
aelias_OOO_until_Jul13
Hi Jared, PTAL. This seems to work okay when I try it out locally, but ...
6 years, 5 months ago (2014-07-21 23:34:55 UTC) #1
jdduke (slow)
On 2014/07/21 23:34:55, aelias wrote: > Hi Jared, PTAL. This seems to work okay when ...
6 years, 5 months ago (2014-07-22 00:12:06 UTC) #2
aelias_OOO_until_Jul13
The CQ bit was checked by aelias@chromium.org
6 years, 5 months ago (2014-07-22 00:17:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/405263002/40001
6 years, 5 months ago (2014-07-22 00:17:47 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-22 00:55:22 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 01:29:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/30561)
6 years, 5 months ago (2014-07-22 01:29:41 UTC) #7
aelias_OOO_until_Jul13
The CQ bit was checked by aelias@chromium.org
6 years, 5 months ago (2014-07-22 01:34:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/405263002/40001
6 years, 5 months ago (2014-07-22 01:35:12 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 01:36:46 UTC) #10
Message was sent while issue was closed.
Change committed as 178608

Powered by Google App Engine
This is Rietveld 408576698