Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 405253003: Make RendererExited reset the InputRouter after destroying the window. (Closed)

Created:
6 years, 5 months ago by skobes
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul
Project:
chromium
Visibility:
Public.

Description

Make RendererExited reset the InputRouter after destroying the window. Destroying an Aura window generates a synthetic mouse move event if the mouse is inside the window. This causes the InputRouter to get stuck in a state where it is waiting for the renderer to ack the mouse move. BUG=395737 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285040

Patch Set 1 #

Patch Set 2 : Address review comments. #

Patch Set 3 : Fix Android test failure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M content/browser/renderer_host/input/input_router.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 chunks +7 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 2 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
skobes
6 years, 5 months ago (2014-07-22 00:18:38 UTC) #1
sky
How about a test and a better comment?
6 years, 5 months ago (2014-07-22 04:07:19 UTC) #2
skobes
On 2014/07/22 04:07:19, sky wrote: > How about a test and a better comment? Done.
6 years, 5 months ago (2014-07-22 19:14:33 UTC) #3
sky
Thanks LGTM
6 years, 5 months ago (2014-07-22 21:18:40 UTC) #4
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 5 months ago (2014-07-22 21:21:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/405253003/20001
6 years, 5 months ago (2014-07-22 21:23:44 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 01:08:02 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 02:19:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173674)
6 years, 5 months ago (2014-07-23 02:19:53 UTC) #9
skobes
The CQ bit was checked by skobes@chromium.org
6 years, 5 months ago (2014-07-23 17:15:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skobes@chromium.org/405253003/40001
6 years, 5 months ago (2014-07-23 17:17:46 UTC) #11
skobes
6 years, 5 months ago (2014-07-23 21:10:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 manually as r285040 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698