Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 405163004: Add runtime flag to enable the display list 2D canvas implementation (Closed)

Created:
6 years, 5 months ago by Justin Novosad
Modified:
6 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, creis+watch_chromium.org, nkostylev+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add runtime flag to enable the display list 2D canvas implementation This change adds the command line switch --enable-display-list-2d-canvas and adds a corresponding entry to the chrome://flags page BUG=392594 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285119

Patch Set 1 #

Total comments: 2

Patch Set 2 : Applied corrections #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/child/runtime_features.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Justin Novosad
PTAL
6 years, 5 months ago (2014-07-21 21:29:06 UTC) #1
Justin Novosad
On 2014/07/21 21:29:06, junov wrote: > PTAL Note: CL Depends on Blink r178585. Will start ...
6 years, 5 months ago (2014-07-21 21:32:20 UTC) #2
piman
https://codereview.chromium.org/405163004/diff/1/content/child/runtime_features.cc File content/child/runtime_features.cc (right): https://codereview.chromium.org/405163004/diff/1/content/child/runtime_features.cc#newcode129 content/child/runtime_features.cc:129: if (command_line.HasSwitch(switches::kEnableDisplayList2dCanvas)) This will require you to forward the ...
6 years, 5 months ago (2014-07-21 21:45:56 UTC) #3
Justin Novosad
New patch. https://codereview.chromium.org/405163004/diff/1/content/child/runtime_features.cc File content/child/runtime_features.cc (right): https://codereview.chromium.org/405163004/diff/1/content/child/runtime_features.cc#newcode129 content/child/runtime_features.cc:129: if (command_line.HasSwitch(switches::kEnableDisplayList2dCanvas)) On 2014/07/21 21:45:56, piman (slow ...
6 years, 5 months ago (2014-07-23 18:56:18 UTC) #4
Justin Novosad
More info: WebPreferences part was removed. It was a remnant of an earlier version of ...
6 years, 5 months ago (2014-07-23 18:57:43 UTC) #5
piman
LGTM, thanks!
6 years, 5 months ago (2014-07-23 19:14:01 UTC) #6
Justin Novosad
The CQ bit was checked by junov@chromium.org
6 years, 5 months ago (2014-07-23 19:16:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/405163004/20001
6 years, 5 months ago (2014-07-23 19:19:29 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 02:34:48 UTC) #9
Message was sent while issue was closed.
Change committed as 285119

Powered by Google App Engine
This is Rietveld 408576698