Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 405113002: Add CXX cross-compile detection into Makefile after it was removed from gyp. (Closed)

Created:
6 years, 5 months ago by rmcilroy
Modified:
6 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add CXX cross-compile detection into Makefile after it was removed from gyp. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22509

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Makefile View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
rmcilroy
PTAL Jakob, thanks.
6 years, 5 months ago (2014-07-21 13:31:49 UTC) #1
Jakob Kummerow
lgtm
6 years, 5 months ago (2014-07-21 14:45:43 UTC) #2
rmcilroy
6 years, 5 months ago (2014-07-21 15:26:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22509 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698