Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 405093004: Added dataChannel.id text field to peerconnection.html (Closed)

Created:
6 years, 5 months ago by jansson
Modified:
6 years, 3 months ago
Reviewers:
tnakamura, mcasas
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added dataChannel.id text field to make it easier to test that Chrome/WebRTC reuses the dataChannel id on the same peerConnection. Feature added in issue: https://code.google.com/p/webrtc/issues/detail?id=2646 BUG=NONE TEST=Manual P2P call, dataChannel.id is only displayed when dataChannel.readyState = 'open'. NOTRY=TRUE Committed: https://crrev.com/2d454cf9a5f405dfd78cf581f0e414ff628857b8 Cr-Commit-Position: refs/heads/master@{#291887}

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 1

Patch Set 3 : disable the dataChannel.id element #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/test/data/webrtc/manual/peerconnection.html View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/webrtc/manual/peerconnection_manual.js View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
jansson
Could you perform a code review? Thanks!
6 years, 5 months ago (2014-07-21 09:25:38 UTC) #1
tnakamura
https://codereview.chromium.org/405093004/diff/20001/chrome/test/data/webrtc/manual/peerconnection.html File chrome/test/data/webrtc/manual/peerconnection.html (right): https://codereview.chromium.org/405093004/diff/20001/chrome/test/data/webrtc/manual/peerconnection.html#newcode117 chrome/test/data/webrtc/manual/peerconnection.html:117: <input type="text" id="data-channel-id" size="10"/><br/> Should the data channel ID ...
6 years, 5 months ago (2014-07-21 13:38:26 UTC) #2
jansson
On 2014/07/21 13:38:26, tnakamura wrote: > https://codereview.chromium.org/405093004/diff/20001/chrome/test/data/webrtc/manual/peerconnection.html > File chrome/test/data/webrtc/manual/peerconnection.html (right): > > https://codereview.chromium.org/405093004/diff/20001/chrome/test/data/webrtc/manual/peerconnection.html#newcode117 > ...
6 years, 5 months ago (2014-07-21 13:54:29 UTC) #3
jansson
data-channel-id is now disabled as there is no logic to handle user entered data.
6 years, 5 months ago (2014-07-21 14:00:09 UTC) #4
tnakamura
lgtm
6 years, 5 months ago (2014-07-21 15:28:41 UTC) #5
jansson
The CQ bit was checked by jansson@chromium.org
6 years, 5 months ago (2014-07-22 06:36:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jansson@chromium.org/405093004/40001
6 years, 5 months ago (2014-07-22 06:36:33 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 06:36:34 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-22 06:36:35 UTC) #9
jansson
xians@ could you have a look? It does not seem like tnakamura@ has commit rights ...
6 years, 5 months ago (2014-07-22 08:17:02 UTC) #10
jansson
jansson@chromium.org changed reviewers: + mcasas@chromium.org - xians@chromium.org
6 years, 3 months ago (2014-08-26 11:37:04 UTC) #11
jansson
mcasas@ could PTAL? Submitted a while ago but fell between the chairs, just made a ...
6 years, 3 months ago (2014-08-26 11:37:04 UTC) #12
mcasas
The CQ bit was checked by mcasas@chromium.org
6 years, 3 months ago (2014-08-26 11:40:39 UTC) #13
mcasas
lgtm
6 years, 3 months ago (2014-08-26 11:40:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jansson@chromium.org/405093004/60001
6 years, 3 months ago (2014-08-26 11:40:47 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (60001) as 164b1fba6d25048265f2a788a5f3c00df3b1e450
6 years, 3 months ago (2014-08-26 11:41:29 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:42:13 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2d454cf9a5f405dfd78cf581f0e414ff628857b8
Cr-Commit-Position: refs/heads/master@{#291887}

Powered by Google App Engine
This is Rietveld 408576698