Removed potential memory leak in PasswordFormManager::OnRequestDone

Removed potential memory leak in PasswordFormManager::OnRequestDone

BUG=395190
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285140

[Lukasz Jagielski, 2014-07-21 13:45:07]

Hi,
PTAL at my CL proposition.
Regards,
Łukasz

[Garrett Casto, 2014-07-22 21:06:44]

Would you mind updating this CL to point to bug 395190? I was actually going to
send out a very similar CL to fix the issue pointed out there. I will then add
tests in a later CL. Alternatively I can just send out my own CL instead. Your
call.

https://codereview.chromium.org/405083004/diff/20001/components/password_mana...
File components/password_manager/core/browser/password_form_manager.cc (left):

https://codereview.chromium.org/405083004/diff/20001/components/password_mana...
components/password_manager/core/browser/password_form_manager.cc:399:
best_matches_.clear();
Was this intentional? I'm not sure why you don't want to clear best_matches_
here.

[Lukasz Jagielski, 2014-07-23 14:52:18]

https://codereview.chromium.org/405083004/diff/20001/components/password_mana...
File components/password_manager/core/browser/password_form_manager.cc (left):

https://codereview.chromium.org/405083004/diff/20001/components/password_mana...
components/password_manager/core/browser/password_form_manager.cc:399:
best_matches_.clear();
I removed this, because STLDeleteValues does that already.

On 2014/07/22 21:06:44, Garrett Casto wrote:
> Was this intentional? I'm not sure why you don't want to clear best_matches_
> here.

[Garrett Casto, 2014-07-23 20:18:56]

lgtm

[commit-bot: I haz the power, 2014-07-23 20:20:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ljagielski@opera.com/405083004/20001

[commit-bot: I haz the power, 2014-07-24 03:27:55]

Change committed as 285140