Source/core/dom/Range.h - Issue 405083003: Range.compareBoundaryPoints should throw a NotSupportedError when how has not expected value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Range.h

Issue 405083003: Range.compareBoundaryPoints should throw a NotSupportedError when how has not expected value (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take review comment into consideration Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Range.h

diff --git a/Source/core/dom/Range.h b/Source/core/dom/Range.h

index 925e308ada5324adbc07a71d4e1947ccce2e2dd0..cb6af6a52691fad34b45a76ad03f5f9cd3d90834 100644

--- a/Source/core/dom/Range.h

+++ b/Source/core/dom/Range.h

@@ -72,7 +72,7 @@ public:

enum CompareResults { NODE_BEFORE, NODE_AFTER, NODE_BEFORE_AND_AFTER, NODE_INSIDE };

CompareResults compareNode(Node* refNode, ExceptionState&) const;

enum CompareHow { START_TO_START, START_TO_END, END_TO_END, END_TO_START };

- short compareBoundaryPoints(CompareHow, const Range* sourceRange, ExceptionState&) const;

+ short compareBoundaryPoints(CompareHow, const PassRefPtrWillBeRawPtr<Range> sourceRange, ExceptionState&) const;

static short compareBoundaryPoints(Node* containerA, int offsetA, Node* containerB, int offsetB, ExceptionState&);

static short compareBoundaryPoints(const RangeBoundaryPoint& boundaryA, const RangeBoundaryPoint& boundaryB, ExceptionState&);

bool boundaryPointsValid() const;

« no previous file with comments | « LayoutTests/fast/dom/Range/compareBoundaryPoints-error-expected.txt ('k') | Source/core/dom/Range.cpp » ('j') | Source/core/dom/Range.cpp » ('J')