Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 405073002: Generates Chromecast User-Agent string from current Chromium version. (Closed)

Created:
6 years, 5 months ago by gunsch
Modified:
6 years, 4 months ago
Reviewers:
lcwu1, gunsch-google, MAD
CC:
chromium-reviews, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Generates Chromecast User-Agent string from current Chromium version. R=mad@chromium.org,lcwu@chromium.org BUG=391080 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -5 lines) Patch
M chromecast/chromecast.gyp View 2 chunks +33 lines, -0 lines 0 comments Download
A chromecast/common/version.h.in View 1 chunk +12 lines, -0 lines 0 comments Download
M chromecast/shell/common/cast_content_client.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
gunsch
6 years, 5 months ago (2014-07-21 00:45:12 UTC) #1
gunsch
On 2014/07/21 00:45:12, gunsch wrote: User-Agent with this CL now returns "Mozilla/5.0 (Unknown; Linux x86_64) ...
6 years, 5 months ago (2014-07-21 00:45:53 UTC) #2
gunsch
On 2014/07/21 00:45:53, gunsch wrote: > On 2014/07/21 00:45:12, gunsch wrote: > > User-Agent with ...
6 years, 5 months ago (2014-07-25 03:54:00 UTC) #3
lcwu1
lgtm
6 years, 4 months ago (2014-07-30 02:27:18 UTC) #4
gunsch-google
The CQ bit was checked by gunsch@google.com
6 years, 4 months ago (2014-07-30 02:50:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/405073002/1
6 years, 4 months ago (2014-07-30 02:52:38 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 02:52:40 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-07-30 02:52:41 UTC) #8
gunsch-google
The CQ bit was checked by gunsch@google.com
6 years, 4 months ago (2014-07-31 00:56:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/405073002/1
6 years, 4 months ago (2014-07-31 01:00:21 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-31 01:00:23 UTC) #11
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-07-31 01:00:25 UTC) #12
MAD
This is weird... isn't lcwu@ a committer? Even though he's an OWNER? I thought OWNERS ...
6 years, 4 months ago (2014-07-31 12:12:33 UTC) #13
MAD
lgtm
6 years, 4 months ago (2014-07-31 12:46:50 UTC) #14
gunsch
On 2014/07/31 12:46:50, MAD wrote: > lgtm Thanks for the LG; lcwu@ just became a ...
6 years, 4 months ago (2014-07-31 16:29:40 UTC) #15
gunsch
The CQ bit was unchecked by gunsch@chromium.org
6 years, 4 months ago (2014-07-31 16:29:57 UTC) #16
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-07-31 16:30:09 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/405073002/1
6 years, 4 months ago (2014-07-31 16:31:54 UTC) #18
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 16:43:25 UTC) #19
Message was sent while issue was closed.
Change committed as 286818

Powered by Google App Engine
This is Rietveld 408576698