Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 405026: Fix bug 27217 - disable Java in test_shell by default, to match ... (Closed)

Created:
11 years, 1 month ago by Dirk Pranke
Modified:
9 years, 7 months ago
Reviewers:
eseidel
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Fix bug 27217 - disable Java in test_shell by default, to match DumpRenderTree's behavior. This causes a couple other tests to produce output that could be construed as "failing" (in the way that upstream fails as well). I will file a separate bug in webkit to figure out what to do about them. R=eseidel@chromium.org BUG=27217 TEST=LayoutTests/fast/replaced/applet-rendering-java-disabled.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32479

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : fix EOL for one of the expected.txt files #

Patch Set 5 : try to fix end of line stuff again #

Patch Set 6 : okay, this eol thing is getting weird #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -36 lines) Patch
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/replaced/applet-disabled-positioned-expected.checksum View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/replaced/applet-disabled-positioned-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/replaced/applet-rendering-java-disabled-expected.checksum View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/replaced/applet-rendering-java-disabled-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/tables/mozilla_expected_failures/bugs/bug8499-expected.txt View 1 chunk +118 lines, -0 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/dom/java-applet-calls-expected.txt View 1 2 3 4 5 1 chunk +1 line, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/applet-disabled-positioned-expected.checksum View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/applet-disabled-positioned-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/applet-disabled-positioned-expected.txt View 1 1 chunk +25 lines, -0 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/applet-rendering-java-disabled-expected.checksum View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/applet-rendering-java-disabled-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/applet-rendering-java-disabled-expected.txt View 1 1 chunk +20 lines, -0 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla_expected_failures/bugs/bug8499-expected.checksum View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla_expected_failures/bugs/bug8499-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla_expected_failures/bugs/bug8499-expected.txt View 1 2 3 4 2 chunks +22 lines, -20 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 3 4 1 chunk +0 lines, -7 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Dirk Pranke
11 years, 1 month ago (2009-11-19 01:57:18 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698