Issue 405007: Always start the WebKit thread....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405007: Always start the WebKit thread.... (Closed)

Created:
11 years, 1 month ago by jorlow

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make the WebKitThread object start the WebKit thread on construction (not lazily). NOTE: It's very possible this will have a startup performance impact. I'm going to watch the bots after committing. TODO: Clean up shutdown logic that exists simply because we don't know whether or not we'll ever start the WebKit thread. TEST=The WebKit thread gets spun up early in the initialization process. BUG=24144 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32319

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -68 lines)			Patch
M	chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc	View	10 chunks	+24 lines, -28 lines	0 comments	Download
M	chrome/browser/in_process_webkit/webkit_thread.h	View	2 chunks	+3 lines, -15 lines	0 comments	Download
M	chrome/browser/in_process_webkit/webkit_thread.cc	View	3 chunks	+11 lines, -21 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 1 month ago (2009-11-17 22:08:41 UTC) #2

LGTM, but please revise the CL description before committing.

Expand Messages | Collapse Messages