Issue 405006: Fix build break on Mac release.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 405006: Fix build break on Mac release. (Closed)

Created:
11 years, 1 month ago by jam

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix build break on Mac release. BUG=6844 TBR=darin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32205

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/child_process_launcher.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 1 month ago (2009-11-17 21:01:54 UTC) #2

LGTM

On Tue, Nov 17, 2009 at 12:54 PM, <jam@chromium.org> wrote:

> Reviewers: darin,
>
> Description:
> Fix build break on Mac release.
>
> BUG=6844
> TBR=darin
>
> Please review this at http://codereview.chromium.org/405006
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/child_process_launcher.cc
>
>
> Index: chrome/browser/child_process_launcher.cc
> ===================================================================
> --- chrome/browser/child_process_launcher.cc    (revision 32203)
> +++ chrome/browser/child_process_launcher.cc    (working copy)
> @@ -210,11 +210,12 @@
>  bool ChildProcessLauncher::DidProcessCrash() {
>   bool did_crash, child_exited;
>   base::ProcessHandle handle = context_->process_.handle();
> +#if defined(OS_LINUX)
>   if (context_->zygote_) {
> -#if defined(OS_LINUX)
>     did_crash = Singleton<ZygoteHost>()->DidProcessCrash(handle,
> &child_exited);
> +  } else
>  #endif
> -  } else {
> +  {
>     did_crash = base::DidProcessCrash(&child_exited, handle);
>   }
>
>
>
>

Expand Messages | Collapse Messages