Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 404993002: Move fitBorderToLinesIfNeeded and most of deleteLineBoxTree into RenderBlockFlow. (Closed)

Created:
6 years, 5 months ago by jbroman
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Project:
blink
Visibility:
Public.

Description

Move fitBorderToLinesIfNeeded and most of deleteLineBoxTree into RenderBlockFlow. fitBorderToLinesIfNeeded can only be called on block flows, so it can be moved altogether. deleteLineBoxTree can have its logic moved, leaving (for now) only an ASSERT declaring that it wouldn't have done anything anyway for now. BUG=393945, 302024 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178577

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -65 lines) Patch
M Source/core/rendering/RenderBlock.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 chunks +1 line, -58 lines 1 comment Download
M Source/core/rendering/RenderBlockFlow.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 3 chunks +58 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jbroman
6 years, 5 months ago (2014-07-19 16:01:51 UTC) #1
leviw_travelin_and_unemployed
LGTM. https://codereview.chromium.org/404993002/diff/20001/Source/core/rendering/RenderBlock.cpp File Source/core/rendering/RenderBlock.cpp (right): https://codereview.chromium.org/404993002/diff/20001/Source/core/rendering/RenderBlock.cpp#newcode975 Source/core/rendering/RenderBlock.cpp:975: ASSERT(!m_lineBoxes.firstLineBox()); Your subject line led me to believe ...
6 years, 5 months ago (2014-07-21 18:36:45 UTC) #2
jbroman
On 2014/07/21 18:36:45, leviw wrote: > LGTM. > > https://codereview.chromium.org/404993002/diff/20001/Source/core/rendering/RenderBlock.cpp > File Source/core/rendering/RenderBlock.cpp (right): > ...
6 years, 5 months ago (2014-07-21 18:41:37 UTC) #3
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 5 months ago (2014-07-21 18:41:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/404993002/20001
6 years, 5 months ago (2014-07-21 18:42:22 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 19:18:56 UTC) #6
Message was sent while issue was closed.
Change committed as 178577

Powered by Google App Engine
This is Rietveld 408576698