PasswordManager - SetUpOnMainThread() browsertest clean up

PasswordManager - SetUpOnMainThread clean up

Clean up patch to move kEnableAutomaticPasswordSaving check
to SetUpMainThread().

BUG=393567
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284472

[Nikhil, 2014-07-19 14:36:31]

Clean up patch for PasswordManager browser tests.

PTAL, Thanks!

[vabr (Chromium), 2014-07-21 07:14:02]

Thank you, LGTM provided the tests run fine.

In the future, please make sure you at least comment on the bugtracker, that you
take up a particular task -- http://crbug.com/393567 has no sign of you working
on it, and somebody else might well have started fixing the same thing.

Cheers,
Vaclav

[Nikhil, 2014-07-21 08:17:04]

On 2014/07/21 07:14:02, vabr (Chromium) wrote:
> Thank you, LGTM provided the tests run fine.
> 
> In the future, please make sure you at least comment on the bugtracker, that
you
> take up a particular task -- http://crbug.com/393567 has no sign of you
working
> on it, and somebody else might well have started fixing the same thing.
> 
> Cheers,
> Vaclav

Noted, I'll make sure to comment on tracker. 

Also, I tested locally earlier with --gtest_filter=PasswordManagerBrowserTest.*
and all passed.

[vabr (Chromium), 2014-07-21 08:32:31]

On 2014/07/21 08:17:04, Nikhil wrote:
> On 2014/07/21 07:14:02, vabr (Chromium) wrote:
> > Thank you, LGTM provided the tests run fine.
> > 
> > In the future, please make sure you at least comment on the bugtracker, that
> you
> > take up a particular task -- http://crbug.com/393567 has no sign of you
> working
> > on it, and somebody else might well have started fixing the same thing.
> > 
> > Cheers,
> > Vaclav
> 
> Noted, I'll make sure to comment on tracker. 
> 
> Also, I tested locally earlier with
--gtest_filter=PasswordManagerBrowserTest.*
> and all passed.

Awesome, thanks for both confirmations.
Feel free to check the Commit checkbox.
Thanks for your work!
Vaclav

[Nikhil, 2014-07-21 09:22:39]

The CQ bit was checked by n.bansal@samsung.com

[commit-bot: I haz the power, 2014-07-21 09:23:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/n.bansal@samsung.com/404983002/1

[commit-bot: I haz the power, 2014-07-21 11:08:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-21 12:26:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-21 12:26:04]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[Nikhil, 2014-07-21 17:46:38]

The CQ bit was checked by n.bansal@samsung.com

[commit-bot: I haz the power, 2014-07-21 17:48:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/n.bansal@samsung.com/404983002/1

[commit-bot: I haz the power, 2014-07-21 19:22:51]

Change committed as 284472