Source/devtools/front_end/components/ObjectPopoverHelper.js - Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/components/ObjectPopoverHelper.js

Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address aandrey's comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/jump-to-previous-editing-location.html ('k') | Source/devtools/front_end/console/ConsoleViewMessage.js » ('j') | Source/devtools/front_end/network/NetworkPanel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/components/ObjectPopoverHelper.js

diff --git a/Source/devtools/front_end/components/ObjectPopoverHelper.js b/Source/devtools/front_end/components/ObjectPopoverHelper.js

index 274229c35c0f3a7e5321f4536e655018d6a864c4..d4533c976701950ff12aca2c4af1f35a41642280 100644

--- a/Source/devtools/front_end/components/ObjectPopoverHelper.js

+++ b/Source/devtools/front_end/components/ObjectPopoverHelper.js

@@ -81,16 +81,14 @@ WebInspector.ObjectPopoverHelper.prototype = {

functionName.textContent = response.functionName || WebInspector.UIString("(anonymous function)");

var rawLocation = response.location;

- var link;

- if (rawLocation) {

+ var sourceURL = response.sourceURL;

+ if (rawLocation && sourceURL) {

this._linkifier = new WebInspector.Linkifier();

- link = this._linkifier.linkifyRawLocation(rawLocation, "function-location-link");

- }

- if (link)

+ var link = this._linkifier.linkifyRawLocation(rawLocation, sourceURL, "function-location-link");

title.appendChild(link);

aandrey 2014/07/30 10:01:23 if (link)

sergeyv 2014/07/30 13:43:01 We do not need if anymore

+ }

container.appendChild(popoverContentElement);

popover.show(container, anchorElement);

}