Source/devtools/front_end/timeline/TimelineUIUtils.js - Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase on master Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/console/ConsoleViewMessage.js ('K') | « Source/devtools/front_end/sdk/Target.js ('k') | Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/timeline/TimelineUIUtils.js

diff --git a/Source/devtools/front_end/timeline/TimelineUIUtils.js b/Source/devtools/front_end/timeline/TimelineUIUtils.js

index f9de289821abb7b3e5ed5164571d7be2a194bc0a..b37a02579ab9c0782f5cf62045202f06cc52aff0 100644

--- a/Source/devtools/front_end/timeline/TimelineUIUtils.js

+++ b/Source/devtools/front_end/timeline/TimelineUIUtils.js

@@ -548,7 +548,7 @@ WebInspector.TimelineDetailsContentHelper.prototype = {

{

if (!this._linkifier || !this._target)

return;

- this.appendElementRow(title, this._linkifier.linkifyLocation(this._target, url, line - 1) || "");

+ this.appendElementRow(title, this._linkifier.linkifyScriptLocation(this._target, null, url, line - 1) || "");

/**

@@ -569,7 +569,7 @@ WebInspector.TimelineDetailsContentHelper.prototype = {

var row = stackTraceElement.createChild("div");

row.createTextChild(stackFrame.functionName || WebInspector.UIString("(anonymous function)"));

row.createTextChild(" @ ");

- var urlElement = this._linkifier.linkifyLocationByScriptId(this._target, stackFrame.scriptId, stackFrame.url, stackFrame.lineNumber - 1, stackFrame.columnNumber - 1);

+ var urlElement = this._linkifier.linkifyScriptLocation(this._target, stackFrame.scriptId, stackFrame.url, stackFrame.lineNumber - 1, stackFrame.columnNumber - 1);

row.appendChild(urlElement);

}