Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1646)

Unified Diff: Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase on master Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/Source/devtools/front_end/console/ConsoleViewMessage.js b/Source/devtools/front_end/console/ConsoleViewMessage.js
index 0eb785e25b215ae914393642f5c637019a4be1f7..b457432a6a7e2c13668a4915776aae7a3a7520cf 100644
--- a/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -266,7 +266,7 @@ WebInspector.ConsoleViewMessage.prototype = {
return this._linkifier.linkifyCSSLocation(cssLocation, "console-message-url");
}
- return this._linkifier.linkifyLocation(target, url, lineNumber, columnNumber, "console-message-url");
+ return this._linkifier.linkifyScriptLocation(target, null, url, lineNumber, columnNumber, "console-message-url");
},
/**
@@ -277,10 +277,13 @@ WebInspector.ConsoleViewMessage.prototype = {
{
console.assert(this._linkifier);
var target = this._target();
- if (!this._linkifier || !target)
+ if (!this._linkifier)
return null;
- var rawLocation = this._target().debuggerModel.createRawLocationByConsoleCallFrame(callFrame);
- return this._linkifier.linkifyRawLocation(rawLocation, "console-message-url");
+
+ // FIXME(62725): stack trace line/column numbers are one-based.
aandrey 2014/07/29 16:50:22 I moved this FIXME into one place, why undo this w
sergeyv 2014/07/30 09:31:13 Done.
+ var lineNumber = callFrame.lineNumber ? callFrame.lineNumber - 1 : 0;
+ var columnNumber = callFrame.columnNumber ? callFrame.columnNumber - 1 : 0;
+ return this._linkifier.linkifyScriptLocation(target, callFrame.scriptId, callFrame.url, lineNumber, columnNumber, "console-message-url");
},
/**

Powered by Google App Engine
This is Rietveld 408576698