Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js - Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address aandrey's comments #2 Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/profiler/CanvasProfileView.js ('k') | Source/devtools/front_end/profiler/HeapSnapshotView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

diff --git a/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js b/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

index 2c000a84db533c6c01abf520fcde0588d438e3e9..d69d943941d136318fa88f4fc46b4e55d049cdf8 100644

--- a/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

+++ b/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

@@ -1490,7 +1490,7 @@ WebInspector.AllocationGridNode.prototype = {

var target = this._dataGrid.target();

if (allocationNode.scriptId) {

var linkifier = this._dataGrid._linkifier;

- var urlElement = linkifier.linkifyLocationByScriptId(target, String(allocationNode.scriptId), allocationNode.scriptName, allocationNode.line - 1, allocationNode.column - 1, "profile-node-file");

+ var urlElement = linkifier.linkifyScriptLocation(target, String(allocationNode.scriptId), allocationNode.scriptName, allocationNode.line - 1, allocationNode.column - 1, "profile-node-file");

urlElement.style.maxWidth = "75%";

cell.insertBefore(urlElement, cell.firstChild);

}

« no previous file with comments | « Source/devtools/front_end/profiler/CanvasProfileView.js ('k') | Source/devtools/front_end/profiler/HeapSnapshotView.js » ('j') | no next file with comments »