Source/devtools/front_end/elements/EventListenersSidebarPane.js - Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/elements/EventListenersSidebarPane.js

Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/console/ConsoleViewMessage.js ('k') | Source/devtools/front_end/sdk/DOMModel.js » ('j') | Source/devtools/front_end/sdk/Linkifier.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/elements/EventListenersSidebarPane.js

diff --git a/Source/devtools/front_end/elements/EventListenersSidebarPane.js b/Source/devtools/front_end/elements/EventListenersSidebarPane.js

index a639a53f2ffc2fbf47c437329ae2b1655d3ab278..7ae60ca695509e5bb97aff98b5426dfd3b487639 100644

--- a/Source/devtools/front_end/elements/EventListenersSidebarPane.js

+++ b/Source/devtools/front_end/elements/EventListenersSidebarPane.js

@@ -267,7 +267,9 @@ WebInspector.EventListenerBar.prototype = {

_setFunctionSubtitle: function(linkifier)

{

this.subtitleElement.removeChildren();

- this.subtitleElement.appendChild(linkifier.linkifyRawLocation(this._eventListener.location()));

+ var location = this._eventListener.location();

+ var link = linkifier.linkifyLocationByScriptId(location.target(), location.scriptId, this._eventListener.sourceName(), location.lineNumber, location.columnNumber);

+ this.subtitleElement.appendChild(link);

__proto__: WebInspector.ObjectPropertiesSection.prototype