Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: Source/devtools/front_end/timeline/TracingTimelineUIUtils.js

Issue 404953004: DevTools: Refactor linkifyRawLocation to use fallback url (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address aandrey's comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.TimelineUIUtils} 7 * @extends {WebInspector.TimelineUIUtils}
8 */ 8 */
9 WebInspector.TracingTimelineUIUtils = function() 9 WebInspector.TracingTimelineUIUtils = function()
10 { 10 {
(...skipping 439 matching lines...) Expand 10 before | Expand all | Expand 10 after
450 * @param {string} url 450 * @param {string} url
451 * @param {number} lineNumber 451 * @param {number} lineNumber
452 * @param {number=} columnNumber 452 * @param {number=} columnNumber
453 */ 453 */
454 function linkifyLocation(scriptId, url, lineNumber, columnNumber) 454 function linkifyLocation(scriptId, url, lineNumber, columnNumber)
455 { 455 {
456 if (!url) 456 if (!url)
457 return null; 457 return null;
458 458
459 // FIXME(62725): stack trace line/column numbers are one-based. 459 // FIXME(62725): stack trace line/column numbers are one-based.
460 return linkifier.linkifyLocationByScriptId(target, scriptId, url, lineNu mber - 1, (columnNumber ||1) - 1, "timeline-details"); 460 return linkifier.linkifyScriptLocation(target, scriptId, url, lineNumber - 1, (columnNumber ||1) - 1, "timeline-details");
461 } 461 }
462 462
463 /** 463 /**
464 * @param {!ConsoleAgent.CallFrame} callFrame 464 * @param {!ConsoleAgent.CallFrame} callFrame
465 */ 465 */
466 function linkifyCallFrame(callFrame) 466 function linkifyCallFrame(callFrame)
467 { 467 {
468 return linkifyLocation(callFrame.scriptId, callFrame.url, callFrame.line Number, callFrame.columnNumber); 468 return linkifyLocation(callFrame.scriptId, callFrame.url, callFrame.line Number, callFrame.columnNumber);
aandrey 2014/07/30 10:01:23 ditto
sergeyv 2014/07/30 13:43:01 Done.
469 } 469 }
470 470
471 /** 471 /**
472 * @return {?Element} 472 * @return {?Element}
473 */ 473 */
474 function linkifyTopCallFrame() 474 function linkifyTopCallFrame()
475 { 475 {
476 var stackTrace = event.stackTrace; 476 var stackTrace = event.stackTrace;
477 if (!stackTrace) { 477 if (!stackTrace) {
478 var initiator = event.initiator; 478 var initiator = event.initiator;
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
810 return result; 810 return result;
811 } 811 }
812 812
813 /** 813 /**
814 * @return {!WebInspector.TracingTimelineModel.Filter} 814 * @return {!WebInspector.TracingTimelineModel.Filter}
815 */ 815 */
816 WebInspector.TracingTimelineUIUtils.hiddenEventsFilter = function() 816 WebInspector.TracingTimelineUIUtils.hiddenEventsFilter = function()
817 { 817 {
818 return new WebInspector.TracingTimelineModel.InclusiveEventNameFilter(WebIns pector.TracingTimelineUIUtils._visibleTypes()); 818 return new WebInspector.TracingTimelineModel.InclusiveEventNameFilter(WebIns pector.TracingTimelineUIUtils._visibleTypes());
819 } 819 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698