DevTools: Refactor linkifyRawLocation to use fallback url

Source/devtools/front_end/console/ConsoleViewMessage.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 248 matching lines @@
             return null;
         // FIXME(62725): stack trace line/column numbers are one-based.
         lineNumber = lineNumber ? lineNumber - 1 : 0;
         columnNumber = columnNumber ? columnNumber - 1 : 0;
         if (this._message.source === WebInspector.ConsoleMessage.MessageSource.CSS) {
             var headerIds = target.cssModel.styleSheetIdsForURL(url);
             var cssLocation = new WebInspector.CSSLocation(target, headerIds[0] || null, url, lineNumber, columnNumber);
             return this._linkifier.linkifyCSSLocation(cssLocation, "console-message-url");
         }
 
-        return this._linkifier.linkifyLocation(target, url, lineNumber, columnNumber, "console-message-url");
+        return this._linkifier.linkifyScriptLocation(target, null, url, lineNumber, columnNumber, "console-message-url");
     },
 
     /**
      * @param {!ConsoleAgent.CallFrame} callFrame
      * @return {?Element}
      */
     _linkifyCallFrame: function(callFrame)
     {
         console.assert(this._linkifier);
         var target = this._target();
-        if (!this._linkifier || !target)
+        if (!this._linkifier)
             return null;
-        var rawLocation = this._target().debuggerModel.createRawLocationByConsoleCallFrame(callFrame);
-        return this._linkifier.linkifyRawLocation(rawLocation, "console-message-url");
+
+        // FIXME(62725): stack trace line/column numbers are one-based.

[aandrey, 2014/07/29 16:50:22]

I moved this FIXME into one place, why undo this work?
why is it different from NetworkPanel?

[sergeyv, 2014/07/30 09:31:13]

Done.

+        var lineNumber = callFrame.lineNumber ? callFrame.lineNumber - 1 : 0;
+        var columnNumber = callFrame.columnNumber ? callFrame.columnNumber - 1 : 0;
+        return this._linkifier.linkifyScriptLocation(target, callFrame.scriptId, callFrame.url, lineNumber, columnNumber, "console-message-url");
     },
 
     /**
      * @param {?Array.<!ConsoleAgent.CallFrame>} stackTrace
      * @return {?ConsoleAgent.CallFrame}
      */
     _callFrameAnchorFromStackTrace: function(stackTrace)
     {
         if (!stackTrace || !stackTrace.length)
             return null;
@@ skipping 964 matching lines @@
     {
         if (!this._wrapperElement) {
             WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this);
             this._wrapperElement.classList.toggle("collapsed", this._collapsed);
         }
         return this._wrapperElement;
     },
 
     __proto__: WebInspector.ConsoleViewMessage.prototype
 }