DevTools: Async call stacks for window.postMessage()

Source/bindings/core/v8/ScriptFunctionCall.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 27 matching lines @@
 #include "bindings/core/v8/V8ObjectConstructor.h"
 #include "bindings/core/v8/V8ScriptRunner.h"
 
 #include <v8.h>
 
 namespace blink {
 
 void ScriptCallArgumentHandler::appendArgument(const ScriptValue& argument)
 {
     if (argument.scriptState() != m_scriptState) {
-        ASSERT_NOT_REACHED();
+        appendArgument();

[yurys, 2014/07/21 12:45:32]

Looks like it should be done in a separate patch.

[aandrey, 2014/07/22 11:08:43]

Done. Extracted to http://crrev.com/412443002

         return;
     }
     m_arguments.append(argument);
 }
 
 void ScriptCallArgumentHandler::appendArgument(const String& argument)
 {
     v8::Isolate* isolate = m_scriptState->isolate();
     ScriptState::Scope scope(m_scriptState.get());
     m_arguments.append(ScriptValue(m_scriptState.get(), v8String(isolate, argument)));
@@ skipping 45 matching lines @@
 {
     v8::Isolate* isolate = m_scriptState->isolate();
     m_arguments.append(ScriptValue(m_scriptState.get(), v8Boolean(argument, isolate)));
 }
 
 void ScriptCallArgumentHandler::appendArgument(const Vector<ScriptValue>& argument)
 {
     v8::Isolate* isolate = m_scriptState->isolate();
     ScriptState::Scope scope(m_scriptState.get());
     v8::Handle<v8::Array> result = v8::Array::New(isolate, argument.size());
-    for (size_t i = 0; i < argument.size(); ++i)
-        result->Set(v8::Integer::New(isolate, i), argument[i].v8Value());
+    for (size_t i = 0; i < argument.size(); ++i) {
+        if (argument[i].scriptState() != m_scriptState)
+            result->Set(v8::Integer::New(isolate, i), v8::Undefined(isolate));
+        else
+            result->Set(v8::Integer::New(isolate, i), argument[i].v8Value());
+    }
     m_arguments.append(ScriptValue(m_scriptState.get(), result));
 }
 
+void ScriptCallArgumentHandler::appendArgument()
+{
+    v8::Isolate* isolate = m_scriptState->isolate();
+    m_arguments.append(ScriptValue(m_scriptState.get(), v8::Undefined(isolate)));
+}
+
 ScriptFunctionCall::ScriptFunctionCall(const ScriptValue& thisObject, const String& name)
     : ScriptCallArgumentHandler(thisObject.scriptState())
     , m_thisObject(thisObject)
     , m_name(name)
 {
 }
 
 ScriptValue ScriptFunctionCall::call(bool& hadException, bool reportExceptions)
 {
     ScriptState::Scope scope(m_scriptState.get());
@@ skipping 54 matching lines @@
     v8::Local<v8::Object> result = V8ObjectConstructor::newInstance(m_scriptState->isolate(), constructor, m_arguments.size(), info.get());
     if (tryCatch.HasCaught()) {
         hadException = true;
         return ScriptValue();
     }
 
     return ScriptValue(m_scriptState.get(), result);
 }
 
 } // namespace blink