Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Side by Side Diff: chrome/browser/ssl/ssl_error_info.cc

Issue 404923002: Update SSL error "detail" strings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: String fix Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ssl/ssl_error_info.h" 5 #include "chrome/browser/ssl/ssl_error_info.h"
6 6
7 #include "base/i18n/time_formatting.h" 7 #include "base/i18n/time_formatting.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "content/public/browser/cert_store.h" 9 #include "content/public/browser/cert_store.h"
10 #include "grit/chromium_strings.h" 10 #include "grit/chromium_strings.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 for (; i < dns_names.size(); ++i) { 51 for (; i < dns_names.size(); ++i) {
52 if (dns_names[i] == cert->subject().common_name) 52 if (dns_names[i] == cert->subject().common_name)
53 break; 53 break;
54 } 54 }
55 if (i == dns_names.size()) 55 if (i == dns_names.size())
56 i = 0; 56 i = 0;
57 details = 57 details =
58 l10n_util::GetStringFUTF16(IDS_CERT_ERROR_COMMON_NAME_INVALID_DETAILS, 58 l10n_util::GetStringFUTF16(IDS_CERT_ERROR_COMMON_NAME_INVALID_DETAILS,
59 UTF8ToUTF16(request_url.host()), 59 UTF8ToUTF16(request_url.host()),
60 net::EscapeForHTML( 60 net::EscapeForHTML(
61 UTF8ToUTF16(dns_names[i])), 61 UTF8ToUTF16(dns_names[i])));
62 UTF8ToUTF16(request_url.host()));
63 short_description = l10n_util::GetStringUTF16( 62 short_description = l10n_util::GetStringUTF16(
64 IDS_CERT_ERROR_COMMON_NAME_INVALID_DESCRIPTION); 63 IDS_CERT_ERROR_COMMON_NAME_INVALID_DESCRIPTION);
65 extra_info.push_back( 64 extra_info.push_back(
66 l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXTRA_INFO_1)); 65 l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXTRA_INFO_1));
67 extra_info.push_back( 66 extra_info.push_back(
68 l10n_util::GetStringFUTF16( 67 l10n_util::GetStringFUTF16(
69 IDS_CERT_ERROR_COMMON_NAME_INVALID_EXTRA_INFO_2, 68 IDS_CERT_ERROR_COMMON_NAME_INVALID_EXTRA_INFO_2,
70 net::EscapeForHTML(UTF8ToUTF16(cert->subject().common_name)), 69 net::EscapeForHTML(UTF8ToUTF16(cert->subject().common_name)),
71 UTF8ToUTF16(request_url.host()))); 70 UTF8ToUTF16(request_url.host())));
72 break; 71 break;
73 } 72 }
74 case CERT_DATE_INVALID: 73 case CERT_DATE_INVALID:
75 extra_info.push_back( 74 extra_info.push_back(
76 l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXTRA_INFO_1)); 75 l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXTRA_INFO_1));
77 if (cert->HasExpired()) { 76 if (cert->HasExpired()) {
78 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXPIRED_TITLE); 77 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXPIRED_TITLE);
79 details = l10n_util::GetStringFUTF16( 78 details = l10n_util::GetStringFUTF16(
80 IDS_CERT_ERROR_EXPIRED_DETAILS, 79 IDS_CERT_ERROR_EXPIRED_DETAILS,
81 UTF8ToUTF16(request_url.host()), 80 UTF8ToUTF16(request_url.host()));
82 UTF8ToUTF16(request_url.host()),
83 base::TimeFormatFriendlyDateAndTime(base::Time::Now()));
84 short_description = 81 short_description =
85 l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXPIRED_DESCRIPTION); 82 l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXPIRED_DESCRIPTION);
86 extra_info.push_back(l10n_util::GetStringUTF16( 83 extra_info.push_back(l10n_util::GetStringUTF16(
87 IDS_CERT_ERROR_EXPIRED_DETAILS_EXTRA_INFO_2)); 84 IDS_CERT_ERROR_EXPIRED_DETAILS_EXTRA_INFO_2));
88 } else { 85 } else {
89 // Then it must be not yet valid. We don't check that it is not yet 86 // Then it must be not yet valid. We don't check that it is not yet
90 // valid as there is still a very unlikely chance that the cert might 87 // valid as there is still a very unlikely chance that the cert might
91 // have become valid since the error occurred. 88 // have become valid since the error occurred.
92 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_NOT_YET_VALID_TITLE); 89 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_NOT_YET_VALID_TITLE);
93 details = l10n_util::GetStringFUTF16( 90 details = l10n_util::GetStringFUTF16(
94 IDS_CERT_ERROR_NOT_YET_VALID_DETAILS, 91 IDS_CERT_ERROR_NOT_YET_VALID_DETAILS,
95 UTF8ToUTF16(request_url.host()), 92 UTF8ToUTF16(request_url.host()));
96 UTF8ToUTF16(request_url.host()),
97 base::TimeFormatFriendlyDateAndTime(base::Time::Now()));
98 short_description = 93 short_description =
99 l10n_util::GetStringUTF16(IDS_CERT_ERROR_NOT_YET_VALID_DESCRIPTION); 94 l10n_util::GetStringUTF16(IDS_CERT_ERROR_NOT_YET_VALID_DESCRIPTION);
100 extra_info.push_back( 95 extra_info.push_back(
101 l10n_util::GetStringUTF16( 96 l10n_util::GetStringUTF16(
102 IDS_CERT_ERROR_NOT_YET_VALID_DETAILS_EXTRA_INFO_2)); 97 IDS_CERT_ERROR_NOT_YET_VALID_DETAILS_EXTRA_INFO_2));
103 } 98 }
104 break; 99 break;
105 case CERT_AUTHORITY_INVALID: 100 case CERT_AUTHORITY_INVALID:
106 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_AUTHORITY_INVALID_TITLE); 101 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_AUTHORITY_INVALID_TITLE);
107 details = l10n_util::GetStringFUTF16( 102 details = l10n_util::GetStringFUTF16(
(...skipping 29 matching lines...) Expand all
137 break; 132 break;
138 case CERT_NO_REVOCATION_MECHANISM: 133 case CERT_NO_REVOCATION_MECHANISM:
139 title = l10n_util::GetStringUTF16( 134 title = l10n_util::GetStringUTF16(
140 IDS_CERT_ERROR_NO_REVOCATION_MECHANISM_TITLE); 135 IDS_CERT_ERROR_NO_REVOCATION_MECHANISM_TITLE);
141 details = l10n_util::GetStringUTF16( 136 details = l10n_util::GetStringUTF16(
142 IDS_CERT_ERROR_NO_REVOCATION_MECHANISM_DETAILS); 137 IDS_CERT_ERROR_NO_REVOCATION_MECHANISM_DETAILS);
143 short_description = l10n_util::GetStringUTF16( 138 short_description = l10n_util::GetStringUTF16(
144 IDS_CERT_ERROR_NO_REVOCATION_MECHANISM_DESCRIPTION); 139 IDS_CERT_ERROR_NO_REVOCATION_MECHANISM_DESCRIPTION);
145 break; 140 break;
146 case CERT_UNABLE_TO_CHECK_REVOCATION: 141 case CERT_UNABLE_TO_CHECK_REVOCATION:
147 title = l10n_util::GetStringUTF16( 142 // TODO(felt): Hasn't this been deprecated?
148 IDS_CERT_ERROR_UNABLE_TO_CHECK_REVOCATION_TITLE); 143 title = l10n_util::GetStringFUTF16(
144 IDS_CERT_ERROR_UNABLE_TO_CHECK_REVOCATION_TITLE,
145 UTF8ToUTF16(request_url.host()));
149 details = l10n_util::GetStringUTF16( 146 details = l10n_util::GetStringUTF16(
150 IDS_CERT_ERROR_UNABLE_TO_CHECK_REVOCATION_DETAILS); 147 IDS_CERT_ERROR_UNABLE_TO_CHECK_REVOCATION_DETAILS);
151 short_description = l10n_util::GetStringUTF16( 148 short_description = l10n_util::GetStringUTF16(
152 IDS_CERT_ERROR_UNABLE_TO_CHECK_REVOCATION_DESCRIPTION); 149 IDS_CERT_ERROR_UNABLE_TO_CHECK_REVOCATION_DESCRIPTION);
153 break; 150 break;
154 case CERT_REVOKED: 151 case CERT_REVOKED:
155 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_REVOKED_CERT_TITLE); 152 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_REVOKED_CERT_TITLE);
156 details = l10n_util::GetStringFUTF16(IDS_CERT_ERROR_REVOKED_CERT_DETAILS, 153 details = l10n_util::GetStringFUTF16(IDS_CERT_ERROR_REVOKED_CERT_DETAILS,
157 UTF8ToUTF16(request_url.host())); 154 UTF8ToUTF16(request_url.host()));
158 short_description = 155 short_description =
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 cert_id, &cert); 315 cert_id, &cert);
319 DCHECK(r); 316 DCHECK(r);
320 } 317 }
321 if (errors) 318 if (errors)
322 errors->push_back( 319 errors->push_back(
323 SSLErrorInfo::CreateError(kErrorTypes[i], cert.get(), url)); 320 SSLErrorInfo::CreateError(kErrorTypes[i], cert.get(), url));
324 } 321 }
325 } 322 }
326 return count; 323 return count;
327 } 324 }
OLDNEW
« chrome/app/chromium_strings.grd ('K') | « chrome/app/google_chrome_strings.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698