Break dependency of native_viewport_service on mojo::shell::Context

Break dependency of native_viewport_service on mojo::shell::Context

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284660

[DaveMoore, 2014-07-18 22:14:23]

Cleanup

[darin (slow to review), 2014-07-19 04:26:30]

https://codereview.chromium.org/404913002/diff/20001/mojo/shell/context.h
File mojo/shell/context.h (right):

https://codereview.chromium.org/404913002/diff/20001/mojo/shell/context.h#new...
mojo/shell/context.h:30: class Context : public services::NativeViewportContext
{
Maybe instead of subclassing NativeViewportContext, Context should have an
instance of a NativeViewportContextImpl as a member variable? That would enable
you to hide more of this Android cruft. Or maybe that'd create other
awkwardnesses...

[qsr, 2014-07-21 08:20:25]

https://codereview.chromium.org/404913002/diff/20001/mojo/services/native_vie...
File mojo/services/native_viewport/native_viewport_android.cc (right):

https://codereview.chromium.org/404913002/diff/20001/mojo/services/native_vie...
mojo/services/native_viewport/native_viewport_android.cc:106:
Java_NativeViewportAndroid_createForActivity(env, context_->GetActivity(),
Any reason not to use base::android::GetApplicationContext() from
base/android/jni_android.h

 That remove the context alltogether.

[DaveMoore, 2014-07-21 16:07:05]

Move call to GetApplicationContext() to native_viewport_android

[DaveMoore, 2014-07-21 16:12:54]

Move call to GetApplicationContext() to native_viewport_android

[DaveMoore, 2014-07-21 16:15:06]

Move call to GetApplicationContext() to native_viewport_android

[DaveMoore, 2014-07-21 16:19:29]

Thanks to qsr@ for telling me I can just call
base::android::GetApplicationContext() from native_viewport_android. This is
true as long we don't have our own copy of base, which according to him has to
be true to access the android framework in general (meaning we have to link this
code into the shell as we are here). This simplifies a lot of the NVS wiring
code.

[qsr, 2014-07-21 16:24:04]

lgtm

[DaveMoore, 2014-07-21 16:39:02]

Move call to GetApplicationContext() to native_viewport_android

[DaveMoore, 2014-07-21 16:39:31]

The CQ bit was checked by davemoore@chromium.org

[commit-bot: I haz the power, 2014-07-21 16:40:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davemoore@chromium.org/404913002/90001

[commit-bot: I haz the power, 2014-07-21 18:34:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-21 19:12:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-21 19:13:00]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[qsr, 2014-07-22 08:12:37]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-07-22 08:14:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davemoore@chromium.org/404913002/90001

[commit-bot: I haz the power, 2014-07-22 09:00:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-22 10:39:45]

Change committed as 284660