Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 404893002: Add an XPC implementation of sandbox::MessageServer. (Closed)

Created:
6 years, 5 months ago by Robert Sesek
Modified:
6 years, 5 months ago
Reviewers:
Mark Mentovai, sergeyv
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Add an XPC implementation of sandbox::MessageServer. BUG=382931 R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284288

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+446 lines, -1 line) Patch
M sandbox/mac/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
M sandbox/mac/sandbox_mac.gypi View 3 chunks +5 lines, -0 lines 0 comments Download
M sandbox/mac/xpc.h View 2 chunks +9 lines, -0 lines 0 comments Download
A sandbox/mac/xpc.cc View 1 chunk +20 lines, -0 lines 0 comments Download
A sandbox/mac/xpc_message_server.h View 1 chunk +62 lines, -0 lines 0 comments Download
A sandbox/mac/xpc_message_server.cc View 1 chunk +116 lines, -0 lines 0 comments Download
A sandbox/mac/xpc_message_server_unittest.cc View 1 chunk +219 lines, -0 lines 0 comments Download
M sandbox/mac/xpc_private_stubs.sig View 1 chunk +3 lines, -1 line 0 comments Download
M sandbox/mac/xpc_stubs.sig View 1 chunk +3 lines, -0 lines 0 comments Download
M sandbox/mac/xpc_stubs_header.fragment View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Robert Sesek
6 years, 5 months ago (2014-07-18 20:42:55 UTC) #1
Mark Mentovai
LGTM
6 years, 5 months ago (2014-07-18 21:59:20 UTC) #2
Robert Sesek
The CQ bit was checked by rsesek@chromium.org
6 years, 5 months ago (2014-07-18 22:15:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/404893002/1
6 years, 5 months ago (2014-07-18 22:19:04 UTC) #4
commit-bot: I haz the power
Change committed as 284288
6 years, 5 months ago (2014-07-19 02:30:14 UTC) #5
sergeyv
This patch breaks compilation on macs with sdk 10.8 or 10.9 (I have both, and ...
6 years, 5 months ago (2014-07-19 09:53:07 UTC) #6
sergeyv
6 years, 5 months ago (2014-07-19 10:01:46 UTC) #7
Message was sent while issue was closed.
I filed an issue: crbug.com/395364

Powered by Google App Engine
This is Rietveld 408576698