Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 404833003: Move HTMLLabelElement-related complexity out of Element (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Move HTMLLabelElement-related complexity out of Element Move HTMLLabelElement-related complexity out of Element and into the HTMLLabelElement class. R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -33 lines) Patch
M Source/core/dom/Element.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 4 chunks +0 lines, -32 lines 0 comments Download
M Source/core/html/HTMLLabelElement.h View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/html/HTMLLabelElement.cpp View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 5 months ago (2014-07-20 22:02:19 UTC) #1
tkent
lgtm
6 years, 5 months ago (2014-07-22 00:37:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/404833003/1
6 years, 5 months ago (2014-07-22 00:38:06 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 00:41:48 UTC) #4
Message was sent while issue was closed.
Change committed as 178607

Powered by Google App Engine
This is Rietveld 408576698