Removing the * from hosts and adding the words 'all' and 'site'.

extensions/common/permissions/permission_message_util.cc

Index: extensions/common/permissions/permission_message_util.cc
diff --git a/extensions/common/permissions/permission_message_util.cc b/extensions/common/permissions/permission_message_util.cc
index 0b2e1a9c038d6fba4e62590ecf20711cab511b6a..4754b8f1cbe331d200521ef5ab0902725730ec95 100644
--- a/extensions/common/permissions/permission_message_util.cc
+++ b/extensions/common/permissions/permission_message_util.cc
@@ -38,54 +38,51 @@ bool RcdBetterThan(const std::string& a, const std::string& b) {
 namespace permission_message_util {
 
 PermissionMessage CreateFromHostList(const std::set<std::string>& hosts) {
-  std::vector<std::string> host_list(hosts.begin(), hosts.end());
-  DCHECK(host_list.size());
+  std::vector<base::string16> host_list;
   PermissionMessage::ID message_id;
   base::string16 message;
   base::string16 details;

[not at google - send to devlin, 2014/07/23 01:32:45]

nits: declare these 3 (or 2) variables only when you need them.

[mhm, 2014/07/23 02:38:45]

Done.

+  const uint32_t kMaxBeforeListOfHosts = 3;

[not at google - send to devlin, 2014/07/23 01:32:45]

size_t?

[mhm, 2014/07/23 02:38:45]

Done.

+  typedef std::pair<PermissionMessage::ID, int> MsgPair;
+  int host_msg_id = hosts.size() <= kMaxBeforeListOfHosts
+                        ? IDS_EXTENSION_PROMPT_WARNING_HOST_AND_SUBDOMAIN
+                        : IDS_EXTENSION_PROMPT_WARNING_HOST_AND_SUBDOMAIN_LIST;
+  const MsgPair kMessagesList[kMaxBeforeListOfHosts + 1] = {

[not at google - send to devlin, 2014/07/23 01:32:45]

do you even need to specify a size here? I would have thought you can just go

const MsgPair kMessagesList[] = {
 ...
};

the nice part about that is then you can get rid of kMaxBeforeListOfHosts
entirely and use arraysize(kMessagesList) when needed (very slightly different
logic needed of course).

[mhm, 2014/07/23 02:38:45]

Done.

+      std::make_pair(PermissionMessage::kHosts1,
+                     IDS_EXTENSION_PROMPT_WARNING_1_HOST),
+      std::make_pair(PermissionMessage::kHosts2,
+                     IDS_EXTENSION_PROMPT_WARNING_2_HOSTS),
+      std::make_pair(PermissionMessage::kHosts3,
+                     IDS_EXTENSION_PROMPT_WARNING_3_HOSTS),
+      std::make_pair(PermissionMessage::kHosts4OrMore,
+                     IDS_EXTENSION_PROMPT_WARNING_HOSTS_4_OR_MORE_HOSTS)};
+
+  for (std::set<std::string>::const_iterator it = hosts.begin();
+       it != hosts.end();
+       ++it) {
+    std::string host = *it;
+    host_list.push_back(
+        host[0] == '*' && host[1] == '.'
+            ? l10n_util::GetStringFUTF16(host_msg_id,
+                                         base::UTF8ToUTF16(host.erase(0, 2)))
+            : base::UTF8ToUTF16(host));
+  }
+  DCHECK(host_list.size());
 
-  switch (host_list.size()) {
-    case 1:
-      message_id = PermissionMessage::kHosts1;
-      message = l10n_util::GetStringFUTF16(IDS_EXTENSION_PROMPT_WARNING_1_HOST,
-                                           base::UTF8ToUTF16(host_list[0]));
-      break;
-    case 2:
-      message_id = PermissionMessage::kHosts2;
-      message = l10n_util::GetStringFUTF16(IDS_EXTENSION_PROMPT_WARNING_2_HOSTS,
-                                           base::UTF8ToUTF16(host_list[0]),
-                                           base::UTF8ToUTF16(host_list[1]));
-      break;
-    case 3:
-      message_id = PermissionMessage::kHosts3;
-      message = l10n_util::GetStringFUTF16(IDS_EXTENSION_PROMPT_WARNING_3_HOSTS,
-                                           base::UTF8ToUTF16(host_list[0]),
-                                           base::UTF8ToUTF16(host_list[1]),
-                                           base::UTF8ToUTF16(host_list[2]));
-      break;
-    default:
-      message_id = PermissionMessage::kHosts4OrMore;
-
-      const int kRetainedFilesMessageIDs[6] = {
-          IDS_EXTENSION_PROMPT_WARNING_HOSTS_DEFAULT,
-          IDS_EXTENSION_PROMPT_WARNING_HOST_SINGULAR,
-          IDS_EXTENSION_PROMPT_WARNING_HOSTS_ZERO,
-          IDS_EXTENSION_PROMPT_WARNING_HOSTS_TWO,
-          IDS_EXTENSION_PROMPT_WARNING_HOSTS_FEW,
-          IDS_EXTENSION_PROMPT_WARNING_HOSTS_MANY, };
-      std::vector<int> message_ids;
-      for (size_t i = 0; i < arraysize(kRetainedFilesMessageIDs); i++) {
-        message_ids.push_back(kRetainedFilesMessageIDs[i]);
-      }
-      message = l10n_util::GetPluralStringFUTF16(message_ids, host_list.size());
-
-      for (size_t i = 0; i < host_list.size(); ++i) {
-        if (i > 0)
-          details += base::ASCIIToUTF16("\n");
-        details += l10n_util::GetStringFUTF16(
-            IDS_EXTENSION_PROMPT_WARNING_HOST_LIST_ENTRY,
-            base::UTF8ToUTF16(host_list[i]));
-      }
+  if (host_list.size() <= kMaxBeforeListOfHosts) {

[not at google - send to devlin, 2014/07/23 01:32:45]

this could be a bit simpler if you used a MsgPair rather than unwrapping them
into a message and message_id.

[mhm, 2014/07/23 02:38:45]

Done.

+    message_id = kMessagesList[host_list.size() - 1].first;
+    message = l10n_util::GetStringFUTF16(
+        kMessagesList[host_list.size() - 1].second, host_list, NULL);
+  } else {
+    message_id = kMessagesList[kMaxBeforeListOfHosts].first;
+    message =
+        l10n_util::GetStringUTF16(kMessagesList[kMaxBeforeListOfHosts].second);
+    for (size_t i = 0; i < host_list.size(); ++i) {
+      if (i > 0)
+        details += base::ASCIIToUTF16("\n");
+      details += l10n_util::GetStringFUTF16(
+          IDS_EXTENSION_PROMPT_WARNING_HOST_LIST_ENTRY, host_list[i]);
+    }
   }
 
   return PermissionMessage(message_id, message, details);