extensions/common/permissions/permission_message_util.cc - Issue 404823009: Removing the * from hosts and adding the words 'all' and 'site'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/permission_message_util.cc

Issue 404823009: Removing the * from hosts and adding the words 'all' and 'site'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/permissions/permission_message_util.cc

diff --git a/extensions/common/permissions/permission_message_util.cc b/extensions/common/permissions/permission_message_util.cc

index 0b2e1a9c038d6fba4e62590ecf20711cab511b6a..f7a64f9a53e914ca7c69d8682e1d74919be0357c 100644

--- a/extensions/common/permissions/permission_message_util.cc

+++ b/extensions/common/permissions/permission_message_util.cc

@@ -109,7 +109,7 @@ std::set<std::string> GetDistinctHosts(const URLPatternSet& host_patterns,

// Add the subdomain wildcard back to the host, if necessary.

if (i->match_subdomains())

- host = "*." + host;

+ host = "all " + host + " sites";

not at google - send to devlin 2014/07/21 21:13:44 this won't localise, you need to actually update t

// If the host has an RCD, split it off so we can detect duplicates.

std::string rcd;

« no previous file with comments | « no previous file | no next file » | no next file with comments »