Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Side by Side Diff: extensions/common/permissions/permission_message_util.cc

Issue 404823009: Removing the * from hosts and adding the words 'all' and 'site'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing kalman@ comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/common/permissions/permission_message_util.h" 5 #include "extensions/common/permissions/permission_message_util.h"
6 6
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "extensions/common/permissions/permission_message.h" 9 #include "extensions/common/permissions/permission_message.h"
10 #include "extensions/common/permissions/permission_set.h" 10 #include "extensions/common/permissions/permission_set.h"
(...skipping 20 matching lines...) Expand all
31 if (a == "org") 31 if (a == "org")
32 return b != "com" && b != "net"; 32 return b != "com" && b != "net";
33 return false; 33 return false;
34 } 34 }
35 35
36 } // namespace 36 } // namespace
37 37
38 namespace permission_message_util { 38 namespace permission_message_util {
39 39
40 PermissionMessage CreateFromHostList(const std::set<std::string>& hosts) { 40 PermissionMessage CreateFromHostList(const std::set<std::string>& hosts) {
41 std::vector<std::string> host_list(hosts.begin(), hosts.end()); 41 typedef std::pair<PermissionMessage::ID, int> MsgPair;
42 const MsgPair kMessagesList[] = {
43 std::make_pair(PermissionMessage::kHosts1,
44 IDS_EXTENSION_PROMPT_WARNING_1_HOST),
45 std::make_pair(PermissionMessage::kHosts2,
46 IDS_EXTENSION_PROMPT_WARNING_2_HOSTS),
47 std::make_pair(PermissionMessage::kHosts3,
48 IDS_EXTENSION_PROMPT_WARNING_3_HOSTS),
49 std::make_pair(PermissionMessage::kHosts4OrMore,
50 IDS_EXTENSION_PROMPT_WARNING_HOSTS_LIST)};
51
52 int host_msg_id = hosts.size() < arraysize(kMessagesList)
53 ? IDS_EXTENSION_PROMPT_WARNING_HOST_AND_SUBDOMAIN
54 : IDS_EXTENSION_PROMPT_WARNING_HOST_AND_SUBDOMAIN_LIST;
55 std::vector<base::string16> host_list;
56 for (std::set<std::string>::const_iterator it = hosts.begin();
57 it != hosts.end();
58 ++it) {
59 std::string host = *it;
60 host_list.push_back(
61 host[0] == '*' && host[1] == '.'
62 ? l10n_util::GetStringFUTF16(host_msg_id,
63 base::UTF8ToUTF16(host.erase(0, 2)))
64 : base::UTF8ToUTF16(host));
65 }
42 DCHECK(host_list.size()); 66 DCHECK(host_list.size());
43 PermissionMessage::ID message_id;
44 base::string16 message;
45 base::string16 details;
46 67
47 switch (host_list.size()) { 68 if (host_list.size() < arraysize(kMessagesList)) {
48 case 1: 69 return PermissionMessage(
49 message_id = PermissionMessage::kHosts1; 70 kMessagesList[host_list.size() - 1].first,
50 message = l10n_util::GetStringFUTF16(IDS_EXTENSION_PROMPT_WARNING_1_HOST, 71 l10n_util::GetStringFUTF16(
51 base::UTF8ToUTF16(host_list[0])); 72 kMessagesList[host_list.size() - 1].second, host_list, NULL));
52 break;
53 case 2:
54 message_id = PermissionMessage::kHosts2;
55 message = l10n_util::GetStringFUTF16(IDS_EXTENSION_PROMPT_WARNING_2_HOSTS,
56 base::UTF8ToUTF16(host_list[0]),
57 base::UTF8ToUTF16(host_list[1]));
58 break;
59 case 3:
60 message_id = PermissionMessage::kHosts3;
61 message = l10n_util::GetStringFUTF16(IDS_EXTENSION_PROMPT_WARNING_3_HOSTS,
62 base::UTF8ToUTF16(host_list[0]),
63 base::UTF8ToUTF16(host_list[1]),
64 base::UTF8ToUTF16(host_list[2]));
65 break;
66 default:
67 message_id = PermissionMessage::kHosts4OrMore;
68
69 const int kRetainedFilesMessageIDs[6] = {
70 IDS_EXTENSION_PROMPT_WARNING_HOSTS_DEFAULT,
71 IDS_EXTENSION_PROMPT_WARNING_HOST_SINGULAR,
72 IDS_EXTENSION_PROMPT_WARNING_HOSTS_ZERO,
73 IDS_EXTENSION_PROMPT_WARNING_HOSTS_TWO,
74 IDS_EXTENSION_PROMPT_WARNING_HOSTS_FEW,
75 IDS_EXTENSION_PROMPT_WARNING_HOSTS_MANY, };
76 std::vector<int> message_ids;
77 for (size_t i = 0; i < arraysize(kRetainedFilesMessageIDs); i++) {
78 message_ids.push_back(kRetainedFilesMessageIDs[i]);
79 }
80 message = l10n_util::GetPluralStringFUTF16(message_ids, host_list.size());
81
82 for (size_t i = 0; i < host_list.size(); ++i) {
83 if (i > 0)
84 details += base::ASCIIToUTF16("\n");
85 details += l10n_util::GetStringFUTF16(
86 IDS_EXTENSION_PROMPT_WARNING_HOST_LIST_ENTRY,
87 base::UTF8ToUTF16(host_list[i]));
88 }
89 } 73 }
90 74
91 return PermissionMessage(message_id, message, details); 75 base::string16 details;
76 for (size_t i = 0; i < host_list.size(); ++i) {
77 if (i > 0)
78 details += base::ASCIIToUTF16("\n");
79 details += l10n_util::GetStringFUTF16(
80 IDS_EXTENSION_PROMPT_WARNING_HOST_LIST_ENTRY, host_list[i]);
81 }
82 return PermissionMessage(
83 kMessagesList[arraysize(kMessagesList) - 1].first,
84 l10n_util::GetStringUTF16(
85 kMessagesList[arraysize(kMessagesList) - 1].second),
86 details);
92 } 87 }
93 88
94 std::set<std::string> GetDistinctHosts(const URLPatternSet& host_patterns, 89 std::set<std::string> GetDistinctHosts(const URLPatternSet& host_patterns,
95 bool include_rcd, 90 bool include_rcd,
96 bool exclude_file_scheme) { 91 bool exclude_file_scheme) {
97 // Use a vector to preserve order (also faster than a map on small sets). 92 // Use a vector to preserve order (also faster than a map on small sets).
98 // Each item is a host split into two parts: host without RCDs and 93 // Each item is a host split into two parts: host without RCDs and
99 // current best RCD. 94 // current best RCD.
100 typedef std::vector<std::pair<std::string, std::string> > HostVector; 95 typedef std::vector<std::pair<std::string, std::string> > HostVector;
101 HostVector hosts_best_rcd; 96 HostVector hosts_best_rcd;
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 // Build up the final vector by concatenating hosts and RCDs. 136 // Build up the final vector by concatenating hosts and RCDs.
142 std::set<std::string> distinct_hosts; 137 std::set<std::string> distinct_hosts;
143 for (HostVector::iterator it = hosts_best_rcd.begin(); 138 for (HostVector::iterator it = hosts_best_rcd.begin();
144 it != hosts_best_rcd.end(); 139 it != hosts_best_rcd.end();
145 ++it) 140 ++it)
146 distinct_hosts.insert(it->first + it->second); 141 distinct_hosts.insert(it->first + it->second);
147 return distinct_hosts; 142 return distinct_hosts;
148 } 143 }
149 144
150 } // namespace permission_message_util 145 } // namespace permission_message_util
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698