Implement DOMPoint of geometry interfaces.

Implement DOMPoint of geometry interfaces.

The DOMPoint can represent a 2D point or 3D point.
This will replace non-standard WebKitPoint in the future.

This CL is dependent on:
https://crrev.com/404473004/

The specification:
http://dev.w3.org/fxtf/geometry/

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V_bJNtOg0oM

BUG=388780
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178747

[zino, 2014-07-21 05:49:21]

Please take a look.

Thank you.

[abarth-chromium, 2014-07-21 06:23:02]

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint.h
File Source/core/dom/DOMPoint.h (right):

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPoint.h:16: static PassRefPtrWillBeRawPtr<DOMPoint>
create(const Dictionary& point)
The implementation of this function should go in the CPP files.

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPoint.h:43: DOMPoint(double x, double y, double z, double w)
Please move the impl to the CPP file.

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
File Source/core/dom/DOMPoint.idl (right):

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPoint.idl:24: inherit attribute unrestricted double w;
What does "inhert" mean?  If we don't support it, we shouldn't have it in the
IDL file.

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
File Source/core/dom/DOMPointReadOnly.h (right):

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPointReadOnly.h:14: class DOMPointReadOnly : public
RefCountedWillBeGarbageCollected<DOMPointReadOnly> {
RefCountedWillBeGarbageCollected -> GarbageCollected

There's no reason to use transitional types.  Let's live in the future.

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPointReadOnly.h:24: DOMPointReadOnly(double x, double y,
double z, double w)
Please move to the CPP file.

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
File Source/core/dom/DOMPointReadOnly.idl (right):

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPointReadOnly.idl:6: WillBeGarbageCollected,
GarbageCollected

[zino, 2014-07-21 11:15:26]

Thank you for review.

I addressed your comments.
Could you please review again?

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint.h
File Source/core/dom/DOMPoint.h (right):

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPoint.h:16: static PassRefPtrWillBeRawPtr<DOMPoint>
create(const Dictionary& point)
On 2014/07/21 06:23:01, abarth wrote:
> The implementation of this function should go in the CPP files.

Done.

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPoint.h:43: DOMPoint(double x, double y, double z, double w)
On 2014/07/21 06:23:01, abarth wrote:
> Please move the impl to the CPP file.

Done.

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
File Source/core/dom/DOMPoint.idl (right):

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPoint.idl:24: inherit attribute unrestricted double w;
On 2014/07/21 06:23:01, abarth wrote:
> What does "inhert" mean?  If we don't support it, we shouldn't have it in the
> IDL file.

Done.

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
File Source/core/dom/DOMPointReadOnly.h (right):

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPointReadOnly.h:14: class DOMPointReadOnly : public
RefCountedWillBeGarbageCollected<DOMPointReadOnly> {
On 2014/07/21 06:23:01, abarth wrote:
> RefCountedWillBeGarbageCollected -> GarbageCollected
> 
> There's no reason to use transitional types.  Let's live in the future.

Done.

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPointReadOnly.h:24: DOMPointReadOnly(double x, double y,
double z, double w)
On 2014/07/21 06:23:01, abarth wrote:
> Please move to the CPP file.

Done.

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
File Source/core/dom/DOMPointReadOnly.idl (right):

https://codereview.chromium.org/404803002/diff/20001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPointReadOnly.idl:6: WillBeGarbageCollected,
On 2014/07/21 06:23:01, abarth wrote:
> GarbageCollected

Done.

[haraken, 2014-07-21 14:03:55]

LGTM

bashi@: This is another customer of the IDL dictionary. FYI.

https://codereview.chromium.org/404803002/diff/40001/LayoutTests/fast/dom/geo...
File LayoutTests/fast/dom/geometry-interfaces-dom-point.html (right):

https://codereview.chromium.org/404803002/diff/40001/LayoutTests/fast/dom/geo...
LayoutTests/fast/dom/geometry-interfaces-dom-point.html:4: <title>Geometry
Interfaces: DOMPoint</title>

Nit: No indentation is needed. If you want to indent, use 4-space indentation.

https://codereview.chromium.org/404803002/diff/40001/LayoutTests/fast/dom/geo...
LayoutTests/fast/dom/geometry-interfaces-dom-point.html:10: debug("# DOMPoint(2,
3)");

Ditto.

https://codereview.chromium.org/404803002/diff/40001/Source/core/dom/DOMPoint...
File Source/core/dom/DOMPoint.cpp (right):

https://codereview.chromium.org/404803002/diff/40001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPoint.cpp:12: double x, y, z, w;

I'd guess this will cause uninitialized error in some compilers. You can do:

  double x = 0;
  DictionaryHelper::get(point, "x", x);

[zino, 2014-07-21 15:12:42]

Thank you for lgtm.
Still need approval for Source/platform.
I'm waiting for other reviews.

https://codereview.chromium.org/404803002/diff/40001/LayoutTests/fast/dom/geo...
File LayoutTests/fast/dom/geometry-interfaces-dom-point.html (right):

https://codereview.chromium.org/404803002/diff/40001/LayoutTests/fast/dom/geo...
LayoutTests/fast/dom/geometry-interfaces-dom-point.html:4: <title>Geometry
Interfaces: DOMPoint</title>
On 2014/07/21 14:03:55, haraken wrote:
> 
> Nit: No indentation is needed. If you want to indent, use 4-space indentation.

Done.

https://codereview.chromium.org/404803002/diff/40001/LayoutTests/fast/dom/geo...
LayoutTests/fast/dom/geometry-interfaces-dom-point.html:10: debug("# DOMPoint(2,
3)");
On 2014/07/21 14:03:55, haraken wrote:
> 
> Ditto.

Done.

https://codereview.chromium.org/404803002/diff/40001/Source/core/dom/DOMPoint...
File Source/core/dom/DOMPoint.cpp (right):

https://codereview.chromium.org/404803002/diff/40001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPoint.cpp:12: double x, y, z, w;
On 2014/07/21 14:03:55, haraken wrote:
> 
> I'd guess this will cause uninitialized error in some compilers. You can do:
> 
>   double x = 0;
>   DictionaryHelper::get(point, "x", x);

Done.

[abarth-chromium, 2014-07-21 17:28:37]

platform/ LGTM

[Rik, 2014-07-21 17:57:22]

https://codereview.chromium.org/404803002/diff/60001/Source/core/dom/DOMPoint...
File Source/core/dom/DOMPointReadOnly.idl (right):

https://codereview.chromium.org/404803002/diff/60001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPointReadOnly.idl:8: ] interface DOMPointReadOnly {
The spec was updated to allow construction of this object:
http://dev.w3.org/fxtf/geometry/#DOMPoint

[zino, 2014-07-22 01:27:02]

Thank you for review.

I also added the constructor and some tests.
Please take a look.

https://codereview.chromium.org/404803002/diff/60001/Source/core/dom/DOMPoint...
File Source/core/dom/DOMPointReadOnly.idl (right):

https://codereview.chromium.org/404803002/diff/60001/Source/core/dom/DOMPoint...
Source/core/dom/DOMPointReadOnly.idl:8: ] interface DOMPointReadOnly {
On 2014/07/21 17:57:22, Rik wrote:
> The spec was updated to allow construction of this object:
> http://dev.w3.org/fxtf/geometry/#DOMPoint

Done.

[Rik, 2014-07-22 01:47:22]

lgtm

[zino, 2014-07-22 02:14:33]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-07-22 02:16:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/404803002/80001

[commit-bot: I haz the power, 2014-07-22 03:28:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/16449)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/18095)
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[commit-bot: I haz the power, 2014-07-22 03:57:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 03:57:39]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[zino, 2014-07-22 04:32:08]

FYI, I've updated TestExpectations for global-constructors-listing.html.

[zino, 2014-07-22 04:32:17]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-07-22 04:32:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/404803002/100001

[commit-bot: I haz the power, 2014-07-22 05:38:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/18109)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-22 06:22:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 06:22:17]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/18116)

[zino, 2014-07-22 14:09:10]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-07-22 14:09:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/404803002/100001

[commit-bot: I haz the power, 2014-07-22 14:09:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 14:09:50]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 1313.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
548c491ecc2ab5b4e1f935af9a2603defd9c703e..b4fe030d5c83d10d385ebc18409a5c43a75f50e9
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1313,3 +1313,5 @@ crbug.com/395127
http/tests/w3c/webperf/approved/UserTiming/test_user_timing_mea
 
 # Flaky on Linux ASAN bots.
 crbug.com/395137 [ Linux ] inspector/sources/debugger/script-formatter.html [
Failure Pass ]
+
+crbug.com/388780 webexposed/global-constructors-listing.html [ NeedsRebaseline
]

[zino, 2014-07-23 01:41:04]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-07-23 01:41:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/404803002/120001

[commit-bot: I haz the power, 2014-07-23 05:56:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-23 06:50:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 06:50:57]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[zino, 2014-07-23 06:53:23]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-07-23 06:54:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/404803002/120001

[commit-bot: I haz the power, 2014-07-23 07:47:10]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-23 08:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 08:32:56]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[zino, 2014-07-23 08:36:30]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-07-23 08:37:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/404803002/120001

[commit-bot: I haz the power, 2014-07-23 09:11:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-23 09:41:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 09:41:43]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[zino, 2014-07-23 10:28:58]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2014-07-23 10:29:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/404803002/120001

[commit-bot: I haz the power, 2014-07-23 10:30:49]

Change committed as 178747