Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 404793004: ui/gfx: optimize color format conversions by using memcpy in jpeg_codec.cc (Closed)

Created:
6 years, 5 months ago by hyunki
Modified:
6 years, 5 months ago
Reviewers:
dcheng, Elliot Glaysher, sky, erg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ui/gfx: optimize color format conversions by using memcpy in jpeg_codec.cc This is similar idea which was already applied in png_codec.cc. https://codereview.chromium.org/397673002/ (Sorry for making another review request.) BUG=none R=erg@chromium.org, sky@chromium.org, dcheng@chromium.org TEST(DONE&PASSED)=gfx_unittests --gtest_filter="JPEGCodec*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M ui/gfx/codec/jpeg_codec.cc View 2 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hyunki
Please take a look. :) And sorry for making another review request. Thank you!
6 years, 5 months ago (2014-07-18 13:37:03 UTC) #1
Elliot Glaysher
So do you have measurements that these are better? I'm assuming that you're relying on ...
6 years, 5 months ago (2014-07-18 17:13:26 UTC) #2
hyunki
I see. I'll measure it and share the results. Thanks.
6 years, 5 months ago (2014-07-18 21:37:22 UTC) #3
hyunki
I did simple performance test for StripAlpha() function. * Test environments - pixel_width: 10000000 - ...
6 years, 5 months ago (2014-07-19 04:03:26 UTC) #4
Elliot Glaysher
lgtm
6 years, 5 months ago (2014-07-21 17:59:08 UTC) #5
hyunki
On 2014/07/21 17:59:08, Elliot Glaysher wrote: > lgtm Thanks for the review. :)
6 years, 5 months ago (2014-07-21 19:25:16 UTC) #6
hyunki
The CQ bit was checked by hyunki.baik@samsung.com
6 years, 5 months ago (2014-07-21 19:25:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hyunki.baik@samsung.com/404793004/1
6 years, 5 months ago (2014-07-21 19:26:56 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 23:45:29 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 01:37:10 UTC) #10
Message was sent while issue was closed.
Change committed as 284585

Powered by Google App Engine
This is Rietveld 408576698