Issue 404773002: Version 3.28.28.2 (merged r22456)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 404773002: Version 3.28.28.2 (merged r22456) (Closed)

Created:
6 years, 5 months ago by akos.palfi.imgtec

Modified:
6 years, 5 months ago

Reviewers:
Jakob Kummerow, Michael Achenbach, balazs.kilvady, dusmil.imgtec, danno, gergely.kis.imgtec, paul.l...

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/trunk

Project:
v8

Visibility:
Public.

Version 3.28.28.2 (merged r22456) MIPS: StubCallInterfaceDescriptor and CallInterfaceDescriptor are unified under a base class InterfaceDescriptor. R=jkummerow@chromium.org, machenbach@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22479

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -73 lines)			Patch
M	src/mips/code-stubs-mips.cc	View	19 chunks	+38 lines, -29 lines	0 comments	Download
M	src/mips/lithium-mips.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips64/code-stubs-mips64.cc	View	19 chunks	+37 lines, -29 lines	0 comments	Download
M	src/mips64/lithium-mips64.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/mips64/lithium-mips64.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

Michael Achenbach

On 2014/07/18 12:05:37, Michael Achenbach wrote: > lgtm Please submit a new roll after https://codereview.chromium.org/400933003/ ...

6 years, 5 months ago (2014-07-18 12:06:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r22479.