Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 404753002: Revert of Add WorkerThread based methods for start/stop of worker threads. (Closed)

Created:
6 years, 5 months ago by nasko
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Revert of Add WorkerThread based methods for start/stop of worker threads. (https://codereview.chromium.org/393283003/) Reason for revert: Breaking blink bots. Original issue's description: > Add WorkerThread based methods for start/stop of worker threads. > > This patch adds notification methods for start/stop of worker threads which accept a WorkerThread parameter. This is needed in order to move the worker threads in blink to use WebThread instead of its own version. > It also adds support for shared timer to WebThreadImpl. > > BUG=301515 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284008 TBR=jochen@chromium.org,sigbjornf@opera.com NOTREECHECKS=true NOTRY=true BUG=301515 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284038

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -122 lines) Patch
M content/child/blink_platform_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/child/webthread_impl.h View 3 chunks +0 lines, -18 lines 0 comments Download
M content/child/webthread_impl.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M content/child/worker_task_runner.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/child/worker_task_runner.cc View 4 chunks +8 lines, -58 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nasko
Created Revert of Add WorkerThread based methods for start/stop of worker threads.
6 years, 5 months ago (2014-07-18 09:05:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/404753002/1
6 years, 5 months ago (2014-07-18 09:05:50 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 09:07:00 UTC) #3
Message was sent while issue was closed.
Change committed as 284038

Powered by Google App Engine
This is Rietveld 408576698