Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 404733005: Replace uses of uint8 with uint8_t. (Closed)

Created:
6 years, 5 months ago by eroman
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Replace uses of uint8 with uint8_t. This changelist was generated automatically by: sed -i 's/\<uint8>\>/s BUG=394944 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284319

Patch Set 1 #

Total comments: 10

Patch Set 2 : Address sleevi comments #

Patch Set 3 : rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+353 lines, -329 lines) Patch
M content/child/webcrypto/algorithm_dispatch.h View 1 4 chunks +7 lines, -7 lines 0 comments Download
M content/child/webcrypto/algorithm_dispatch.cc View 1 10 chunks +11 lines, -11 lines 0 comments Download
M content/child/webcrypto/algorithm_implementation.h View 1 4 chunks +9 lines, -8 lines 0 comments Download
M content/child/webcrypto/algorithm_implementation.cc View 4 chunks +12 lines, -10 lines 0 comments Download
M content/child/webcrypto/jwk.h View 1 6 chunks +6 lines, -6 lines 0 comments Download
M content/child/webcrypto/jwk.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/child/webcrypto/nss/aes_cbc_nss.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/webcrypto/nss/aes_gcm_nss.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/webcrypto/nss/aes_key_nss.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/nss/aes_key_nss.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/child/webcrypto/nss/aes_kw_nss.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/webcrypto/nss/hmac_nss.cc View 1 5 chunks +7 lines, -6 lines 0 comments Download
M content/child/webcrypto/nss/key_nss.h View 1 5 chunks +13 lines, -6 lines 0 comments Download
M content/child/webcrypto/nss/key_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/nss/rsa_key_nss.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/webcrypto/nss/rsa_key_nss.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M content/child/webcrypto/nss/rsa_oaep_nss.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/child/webcrypto/nss/rsa_ssa_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/nss/sha_nss.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/openssl/aes_cbc_openssl.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/child/webcrypto/openssl/aes_gcm_openssl.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M content/child/webcrypto/openssl/aes_key_openssl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/openssl/aes_key_openssl.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/child/webcrypto/openssl/aes_kw_openssl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/openssl/hmac_openssl.cc View 1 6 chunks +9 lines, -8 lines 0 comments Download
M content/child/webcrypto/openssl/key_openssl.h View 1 3 chunks +9 lines, -4 lines 0 comments Download
M content/child/webcrypto/openssl/key_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/openssl/sha_openssl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/platform_crypto.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/child/webcrypto/shared_crypto_unittest.cc View 102 chunks +178 lines, -177 lines 0 comments Download
M content/child/webcrypto/structured_clone.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/child/webcrypto/structured_clone.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/webcrypto_impl.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M content/child/webcrypto/webcrypto_util.h View 1 3 chunks +7 lines, -4 lines 0 comments Download
M content/child/webcrypto/webcrypto_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eroman
Note that I didn't include stdint.h explicitly anywhere
6 years, 5 months ago (2014-07-18 21:26:07 UTC) #1
Ryan Sleevi
Fix up the stdints. Annotated below everywhere you need to fix. https://codereview.chromium.org/404733005/diff/1/content/child/webcrypto/algorithm_dispatch.h File content/child/webcrypto/algorithm_dispatch.h (right): ...
6 years, 5 months ago (2014-07-18 23:02:55 UTC) #2
eroman
Thanks! Addressed each of the comments.
6 years, 5 months ago (2014-07-19 00:07:59 UTC) #3
Ryan Sleevi
lgtm
6 years, 5 months ago (2014-07-19 00:10:04 UTC) #4
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 5 months ago (2014-07-19 01:14:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/404733005/40001
6 years, 5 months ago (2014-07-19 01:14:43 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 05:08:44 UTC) #7
Message was sent while issue was closed.
Change committed as 284319

Powered by Google App Engine
This is Rietveld 408576698