chrome/browser/ssl/ssl_browser_tests.cc - Issue 404693002: Test SSLUITest.TestWSSInvalidCertAndClose no longer leaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 404693002: Test SSLUITest.TestWSSInvalidCertAndClose no longer leaks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ssl/ssl_browser_tests.cc

diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc

index 54f61476d425412449d9eabe39ec19a462f60677..2c037f18cdbea665d288d9e356d7ec764fa91d8f 100644

--- a/chrome/browser/ssl/ssl_browser_tests.cc

+++ b/chrome/browser/ssl/ssl_browser_tests.cc

@@ -639,8 +639,7 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, TestHTTPSExpiredCertAndGoForward) {

// certificate. Close the page while WSS connection waits for SSLManager's

// response from UI thread.

// Disabled on Windows because it was flaking on XP Tests (1). crbug.com/165258

-// Disabled under LeakSanitizer due to memory leaks. http://crbug.com/317363

-#if defined(OS_WIN) || defined(LEAK_SANITIZER)

+#if defined(OS_WIN)

#define MAYBE_TestWSSInvalidCertAndClose DISABLED_TestWSSInvalidCertAndClose

#else

#define MAYBE_TestWSSInvalidCertAndClose TestWSSInvalidCertAndClose

« no previous file with comments | « no previous file | no next file » | no next file with comments »