Issue 404683002: athena: Rename athena_resources target to athena_pak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 404683002: athena: Rename athena_resources target to athena_pak. (Closed)

Created:
6 years, 5 months ago by tfarina

Modified:
6 years, 5 months ago

Reviewers:
oshima

CC:
chromium-reviews, sadrul

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

athena: Rename athena_resources target to athena_pak. That way we free a slot for when we add an athena_resources.grd. BUG=None TEST=None R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284268

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	athena/main/athena_main.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	athena/resources/athena_resources.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

Committed patchset #1 manually as r284268 (presubmit successful).

6 years, 5 months ago (2014-07-19 00:55:16 UTC) #3

waffles

6 years, 5 months ago (2014-07-19 01:21:13 UTC) #4

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/393233006/ by waffles@chromium.org.

The reason for reverting is: Breaks Google ChromeOS compile:

/bin/python src/build/gyp_chromium' in
'/b/build/slave/google-chrome-rel-chromeos/build'
Updating projects from gyp files...
gyp: Dependency
'/b/build/slave/google-chrome-rel-chromeos/build/src/athena/resources/athena_resources.gyp:athena_resources#target'
not found while trying to load target
/b/build/slave/google-chrome-rel-chromeos/build/src/athena/athena.gyp:athena_unittests#target.

Expand Messages | Collapse Messages