Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 404653005: Remove a few unused variables, functions, and tables. (Closed)

Created:
6 years, 5 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
Bo Xu
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Remove a few unused variables, functions, and tables. Found by clang's -Wunused-variable, -Wunused-function, -Wunused-const-variable. BUG=none R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/c77e8f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -143 lines) Patch
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 14 chunks +0 lines, -15 lines 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 3 chunks +0 lines, -4 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 6 chunks +0 lines, -12 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_xml_parser.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxge/apple/fx_quartz_device.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_composite.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 9 chunks +7 lines, -9 lines 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_transform.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_font.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M core/src/fxge/ge/fx_ge_path.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 2 chunks +0 lines, -64 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_pageobjs.cpp View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
Please take a look! I tried not to delete any calls with side effects, please ...
6 years, 5 months ago (2014-07-18 17:07:08 UTC) #1
Nico
Bo: Ping.
6 years, 5 months ago (2014-07-21 16:49:36 UTC) #2
Nico
Bo: ping.
6 years, 5 months ago (2014-07-23 00:51:58 UTC) #3
Nico
Bo: Ping.
6 years, 5 months ago (2014-07-24 01:06:34 UTC) #4
Nico
I sent this one to the wrong address too :-(
6 years, 4 months ago (2014-07-28 21:31:04 UTC) #5
Bo Xu
On 2014/07/28 21:31:04, Nico (away) wrote: > I sent this one to the wrong address ...
6 years, 4 months ago (2014-07-28 22:35:53 UTC) #6
Nico
6 years, 4 months ago (2014-07-29 15:55:58 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 manually as rc77e8f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698