Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 404653004: Rename FontPlatformDataLinuxHarfBuzz to FontPlatformDataLinux (Closed)

Created:
6 years, 5 months ago by eae
Modified:
6 years, 5 months ago
Reviewers:
jbroman
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Project:
blink
Visibility:
Public.

Description

Rename FontPlatformDataLinuxHarfBuzz to FontPlatformDataLinux Rename the linux specific FontPlatformData implementation file from FontPlatformDataLinuxHarfBuzz.cpp to FontPlatformDataLinux.cpp as all platforms use HarfBuzz now. R=jbroman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178469

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -155 lines) Patch
M Source/platform/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gyp View 2 chunks +3 lines, -3 lines 2 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/fonts/linux/FontPlatformDataLinux.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D Source/platform/fonts/linux/FontPlatformDataLinuxHarfBuzz.cpp View 1 chunk +0 lines, -151 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
eae
6 years, 5 months ago (2014-07-18 17:52:52 UTC) #1
jbroman
LGTM. Out of curiosity, what's the plan with FontPlatformData.h? It's currently all the Mac-specific code.
6 years, 5 months ago (2014-07-18 17:57:42 UTC) #2
jbroman
https://codereview.chromium.org/404653004/diff/1/Source/platform/blink_platform.gyp File Source/platform/blink_platform.gyp (right): https://codereview.chromium.org/404653004/diff/1/Source/platform/blink_platform.gyp#newcode277 Source/platform/blink_platform.gyp:277: ['exclude', 'fonts/linux/FontPlatformDataLinux\\.cpp$'], Nit: why is both an include and ...
6 years, 5 months ago (2014-07-18 17:58:51 UTC) #3
eae
On 2014/07/18 17:57:42, jbroman wrote: > LGTM. > > Out of curiosity, what's the plan ...
6 years, 5 months ago (2014-07-18 18:00:36 UTC) #4
eae
https://codereview.chromium.org/404653004/diff/1/Source/platform/blink_platform.gyp File Source/platform/blink_platform.gyp (right): https://codereview.chromium.org/404653004/diff/1/Source/platform/blink_platform.gyp#newcode277 Source/platform/blink_platform.gyp:277: ['exclude', 'fonts/linux/FontPlatformDataLinux\\.cpp$'], On 2014/07/18 17:58:51, jbroman wrote: > Nit: ...
6 years, 5 months ago (2014-07-18 18:03:25 UTC) #5
eae
The CQ bit was checked by eae@chromium.org
6 years, 5 months ago (2014-07-18 18:03:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/404653004/1
6 years, 5 months ago (2014-07-18 18:04:14 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 18:07:26 UTC) #8
Message was sent while issue was closed. 
Change committed as 178469

Powered by Google App Engine
This is Rietveld 408576698