Add a histogram for DHCP client status

Add a histogram for DHCP client status

BUG=384897
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284557

[Ilya Sherman, 2014-07-21 20:44:18]

LGTM % comments.  Thanks.

https://codereview.chromium.org/404613009/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/404613009/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:17333: <histogram
name="Network.Shill.DHCPOptionFailureDetected"
Note that this histogram name has "DHCP" in all caps.  It would be nice for the
two histogram names to match.

https://codereview.chromium.org/404613009/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/404613009/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:43079: +  <int value="1" label="Arp
Gateway">
Are you sure that bucket 0 is unused?  Typically, enumerated histograms have 0
as the first bucket.

[Paul Stewart, 2014-07-21 21:01:00]

https://codereview.chromium.org/404613009/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/404613009/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:17333: <histogram
name="Network.Shill.DHCPOptionFailureDetected"
On 2014/07/21 20:44:18, Ilya Sherman wrote:
> Note that this histogram name has "DHCP" in all caps.  It would be nice for
the
> two histogram names to match.

Done.

https://codereview.chromium.org/404613009/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/404613009/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:43079: +  <int value="1" label="Arp
Gateway">
On 2014/07/21 20:44:18, Ilya Sherman wrote:
> Are you sure that bucket 0 is unused?  Typically, enumerated histograms have 0
> as the first bucket.

Done.

[Paul Stewart, 2014-07-21 21:01:08]

The CQ bit was checked by pstew@chromium.org

[commit-bot: I haz the power, 2014-07-21 21:03:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pstew@chromium.org/404613009/20001

[commit-bot: I haz the power, 2014-07-21 23:14:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)

[commit-bot: I haz the power, 2014-07-22 00:28:53]

Change committed as 284557