Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 404613007: Fix DesktopCaptureDeviceTest to shutdown worker pool (Closed)

Created:
6 years, 5 months ago by Sergey Ulanov
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix DesktopCaptureDeviceTest to shutdown worker pool BUG=395357 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284611

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M content/browser/media/capture/desktop_capture_device_unittest.cc View 1 5 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sergey Ulanov
6 years, 5 months ago (2014-07-21 18:35:21 UTC) #1
Ryan Sleevi
https://codereview.chromium.org/404613007/diff/1/content/browser/media/capture/desktop_capture_device_unittest.cc File content/browser/media/capture/desktop_capture_device_unittest.cc (right): https://codereview.chromium.org/404613007/diff/1/content/browser/media/capture/desktop_capture_device_unittest.cc#newcode158 content/browser/media/capture/desktop_capture_device_unittest.cc:158: base::MessageLoop message_loop_; Out of curiousity, does this use any ...
6 years, 5 months ago (2014-07-21 18:43:32 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/404613007/diff/1/content/browser/media/capture/desktop_capture_device_unittest.cc File content/browser/media/capture/desktop_capture_device_unittest.cc (right): https://codereview.chromium.org/404613007/diff/1/content/browser/media/capture/desktop_capture_device_unittest.cc#newcode158 content/browser/media/capture/desktop_capture_device_unittest.cc:158: base::MessageLoop message_loop_; On 2014/07/21 18:43:32, Ryan Sleevi wrote: > ...
6 years, 5 months ago (2014-07-22 00:08:23 UTC) #3
Ryan Sleevi
lgtm
6 years, 5 months ago (2014-07-22 01:04:56 UTC) #4
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-22 01:16:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/404613007/20001
6 years, 5 months ago (2014-07-22 01:19:50 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 03:25:10 UTC) #7
Message was sent while issue was closed. 
Change committed as 284611

Powered by Google App Engine
This is Rietveld 408576698