chrome/browser/extensions/user_script_master.cc - Issue 404613006: Declarative content scripts: Renderer-side: per-extension shared memory regions (lazily loaded)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/user_script_master.cc

Issue 404613006: Declarative content scripts: Renderer-side: per-extension shared memory regions (lazily loaded) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix use of scoped and linked ptrs, better documentation Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/user_script_master.cc

diff --git a/chrome/browser/extensions/user_script_master.cc b/chrome/browser/extensions/user_script_master.cc

index a3e58465001a36a1748ba245f3d8adb4c3e725f5..bbf9f35f985c0437062606c5e630c261e72fee4d 100644

--- a/chrome/browser/extensions/user_script_master.cc

+++ b/chrome/browser/extensions/user_script_master.cc

@@ -544,8 +544,8 @@ void UserScriptMaster::SendUpdate(

return; // This can legitimately fail if the renderer asserts at startup.

if (base::SharedMemory::IsHandleValid(handle_for_process)) {

- process->Send(new ExtensionMsg_UpdateUserScripts(handle_for_process,

- changed_extensions));

+ process->Send(new ExtensionMsg_UpdateUserScripts(

+ handle_for_process, "", changed_extensions));

Devlin 2014/07/28 18:15:27 nit: document anonymous string (I think we also te

Mark Dittmer 2014/07/28 22:21:28 Done.

}

« no previous file with comments | « no previous file | extensions/common/extension_messages.h » ('j') | extensions/common/extension_messages.h » ('J')