Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: extensions/renderer/user_script_set.cc

Issue 404613006: Declarative content scripts: Renderer-side: per-extension shared memory regions (lazily loaded) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes for last round of comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/user_script_set.h ('k') | extensions/renderer/user_script_set_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/user_script_set.cc
diff --git a/extensions/renderer/user_script_set.cc b/extensions/renderer/user_script_set.cc
index 5ab873955f026e98159d5567a4c111821d130c98..8582184bbb68a0a703b40c5934e7da5065b076fb 100644
--- a/extensions/renderer/user_script_set.cc
+++ b/extensions/renderer/user_script_set.cc
@@ -36,7 +36,6 @@ GURL GetDocumentUrlForFrame(blink::WebFrame* frame) {
UserScriptSet::UserScriptSet(const ExtensionSet* extensions)
: extensions_(extensions) {
- content::RenderThread::Get()->AddObserver(this);
}
UserScriptSet::~UserScriptSet() {
@@ -79,42 +78,9 @@ void UserScriptSet::GetInjections(
}
}
-bool UserScriptSet::OnControlMessageReceived(
- const IPC::Message& message) {
- bool handled = true;
- IPC_BEGIN_MESSAGE_MAP(UserScriptSet, message)
- IPC_MESSAGE_HANDLER(ExtensionMsg_UpdateUserScripts, OnUpdateUserScripts)
- IPC_MESSAGE_UNHANDLED(handled = false)
- IPC_END_MESSAGE_MAP()
- return handled;
-}
-
-void UserScriptSet::OnUpdateUserScripts(
+bool UserScriptSet::UpdateUserScripts(
base::SharedMemoryHandle shared_memory,
const std::set<std::string>& changed_extensions) {
- if (!base::SharedMemory::IsHandleValid(shared_memory)) {
- NOTREACHED() << "Bad scripts handle";
- return;
- }
-
- for (std::set<std::string>::const_iterator iter = changed_extensions.begin();
- iter != changed_extensions.end();
- ++iter) {
- if (!Extension::IdIsValid(*iter)) {
- NOTREACHED() << "Invalid extension id: " << *iter;
- return;
- }
- }
-
- if (UpdateScripts(shared_memory)) {
- FOR_EACH_OBSERVER(Observer,
- observers_,
- OnUserScriptsUpdated(changed_extensions, scripts_.get()));
- }
-}
-
-bool UserScriptSet::UpdateScripts(
- base::SharedMemoryHandle shared_memory) {
bool only_inject_incognito =
ExtensionsRendererClient::Get()->IsIncognitoProcess();
@@ -171,6 +137,9 @@ bool UserScriptSet::UpdateScripts(
scripts_.push_back(script.release());
}
+ FOR_EACH_OBSERVER(Observer,
+ observers_,
+ OnUserScriptsUpdated(changed_extensions, scripts_.get()));
return true;
}
« no previous file with comments | « extensions/renderer/user_script_set.h ('k') | extensions/renderer/user_script_set_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698