Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 404613005: Start using RenderFrameProxyHost objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Bug fix + ncarter review comments addressed Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 62c05a05d288b9e7d7f07e8964a7207f2559770b..701dcdbbfeeefebcda8a490018133b4ac1b8c1d9 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -47,6 +47,7 @@
#include "content/common/content_constants_internal.h"
#include "content/common/database_messages.h"
#include "content/common/dom_storage/dom_storage_messages.h"
+#include "content/common/frame_messages.h"
#include "content/common/gpu/client/context_provider_command_buffer.h"
#include "content/common/gpu/client/gpu_channel_host.h"
#include "content/common/gpu/client/gpu_memory_buffer_impl.h"
@@ -90,6 +91,7 @@
#include "content/renderer/media/webrtc_identity_service.h"
#include "content/renderer/net_info_helper.h"
#include "content/renderer/p2p/socket_dispatcher.h"
+#include "content/renderer/render_frame_proxy.h"
#include "content/renderer/render_process_impl.h"
#include "content/renderer/render_view_impl.h"
#include "content/renderer/renderer_webkitplatformsupport_impl.h"
@@ -1274,13 +1276,6 @@ void RenderThreadImpl::DoNotNotifyWebKitOfModalLoop() {
notify_webkit_of_modal_loop_ = false;
}
-void RenderThreadImpl::OnSetZoomLevelForCurrentURL(const std::string& scheme,
Charlie Reis 2014/07/24 22:36:32 Is this from a merge conflict? It seems unrelated
nasko 2014/07/25 07:13:21 I moved it to be ordered according to the .h file.
- const std::string& host,
- double zoom_level) {
- RenderViewZoomer zoomer(scheme, host, zoom_level);
- RenderView::ForEach(&zoomer);
-}
-
bool RenderThreadImpl::OnControlMessageReceived(const IPC::Message& msg) {
ObserverListBase<RenderProcessObserver>::Iterator it(observers_);
RenderProcessObserver* observer;
@@ -1298,6 +1293,8 @@ bool RenderThreadImpl::OnControlMessageReceived(const IPC::Message& msg) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(RenderThreadImpl, msg)
+ IPC_MESSAGE_HANDLER(FrameMsg_NewFrame, OnCreateNewFrame)
+ IPC_MESSAGE_HANDLER(FrameMsg_NewFrameProxy, OnCreateNewFrameProxy)
IPC_MESSAGE_HANDLER(ViewMsg_SetZoomLevelForCurrentURL,
OnSetZoomLevelForCurrentURL)
// TODO(port): removed from render_messages_internal.h;
@@ -1320,6 +1317,29 @@ bool RenderThreadImpl::OnControlMessageReceived(const IPC::Message& msg) {
return handled;
}
+void RenderThreadImpl::OnCreateNewFrame(int routing_id, int parent_routing_id) {
+ // TODO(nasko): For now, this message is only sent for subframes, as the
Charlie Reis 2014/07/24 22:36:32 "For now" -> do we expect that to change? Why?
nasko 2014/07/25 07:13:21 Yes. Once we eliminate RenderView(Host), we need t
+ // top level frame is created when the RenderView is created through the
+ // ViewMsg_New IPC.
+ CHECK(parent_routing_id != MSG_ROUTING_NONE);
+
+ RenderFrameImpl::CreateFrame(routing_id, parent_routing_id);
+}
+
+void RenderThreadImpl::OnCreateNewFrameProxy(int routing_id,
+ int parent_routing_id,
+ int render_view_routing_id) {
+ RenderFrameProxy::CreateFrameProxy(
+ routing_id, parent_routing_id, render_view_routing_id);
+}
+
+void RenderThreadImpl::OnSetZoomLevelForCurrentURL(const std::string& scheme,
+ const std::string& host,
+ double zoom_level) {
+ RenderViewZoomer zoomer(scheme, host, zoom_level);
+ RenderView::ForEach(&zoomer);
+}
+
void RenderThreadImpl::OnCreateNewView(const ViewMsg_New_Params& params) {
EnsureWebKitInitialized();
// When bringing in render_view, also bring in webkit's glue and jsbindings.
@@ -1454,7 +1474,6 @@ void RenderThreadImpl::OnUpdateTimezone() {
NotifyTimezoneChange();
}
-
#if defined(OS_ANDROID)
void RenderThreadImpl::OnSetWebKitSharedTimersSuspended(bool suspend) {
if (suspend_webkit_shared_timer_) {

Powered by Google App Engine
This is Rietveld 408576698