Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2112)

Unified Diff: content/renderer/render_frame_impl.h

Issue 404613005: Start using RenderFrameProxyHost objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Bug fix + ncarter review comments addressed Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 3cd7082e1ea1878ba0807d2003275132b60c41e8..c55517fc2a83e3eb3132d2d267b4c3bcb5ae39a0 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -86,9 +86,20 @@ class CONTENT_EXPORT RenderFrameImpl
// Creates a new RenderFrame. |render_view| is the RenderView object that this
// frame belongs to.
// Callers *must* call |SetWebFrame| immediately after creation.
+ // Note: This is called only when RenderFrame is created by Blink through
+ // createChildFrame.
// TODO(creis): We should structure this so that |SetWebFrame| isn't needed.
static RenderFrameImpl* Create(RenderViewImpl* render_view, int32 routing_id);
+ // Creates a new RenderFrame with |routing_id| as a child of the RenderFrame
+ // identified by |parent_routing_id| or as the top-level frame if
Charlie Reis 2014/07/24 22:36:31 if the latter is
kenrb 2014/07/25 23:42:06 Done.
+ // MSG_ROUTING_NONE. It creates the Blink WebLocalFrame and inserts it in the
+ // proper place in the frame tree.
+ // Note: This is called only when RenderFrame is being created in response to
+ // IPC message from the browser process. All other frame creation is driven
+ // through Blink and Create.
+ static void CreateFrame(int routing_id, int parent_routing_id);
+
// Returns the RenderFrameImpl for the given routing ID.
static RenderFrameImpl* FromRoutingID(int routing_id);

Powered by Google App Engine
This is Rietveld 408576698