Chromium Code Reviews| Index: content/browser/web_contents/web_contents_impl.cc |
| diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc |
| index 5c9cd720bd74ca281485fdac701c09db6cf00c95..d421eb35c2f28479efd9a178502001cb09ebaa15 100644 |
| --- a/content/browser/web_contents/web_contents_impl.cc |
| +++ b/content/browser/web_contents/web_contents_impl.cc |
| @@ -3847,8 +3847,8 @@ WebPreferences WebContentsImpl::GetWebkitPrefs() { |
| int WebContentsImpl::CreateSwappedOutRenderView( |
| SiteInstance* instance) { |
| - return GetRenderManager()->CreateRenderFrame(instance, MSG_ROUTING_NONE, |
| - true, true); |
| + return GetRenderManager()->CreateRenderFrame( |
| + instance, MSG_ROUTING_NONE, true, true, true); |
| } |
| void WebContentsImpl::OnUserGesture() { |
| @@ -4018,8 +4018,8 @@ int WebContentsImpl::CreateOpenerRenderViews(SiteInstance* instance) { |
| // Create a swapped out RenderView in the given SiteInstance if none exists, |
| // setting its opener to the given route_id. Return the new view's route_id. |
| - return GetRenderManager()->CreateRenderFrame(instance, opener_route_id, |
| - true, true); |
| + return GetRenderManager()->CreateRenderFrame( |
| + instance, opener_route_id, true, true, true); |
| } |
| NavigationControllerImpl& WebContentsImpl::GetControllerForRenderManager() { |
| @@ -4085,6 +4085,23 @@ bool WebContentsImpl::CreateRenderViewForRenderManager( |
| return true; |
| } |
| +bool WebContentsImpl::CreateRenderFrameForRenderManager( |
| + RenderFrameHost* render_frame_host, |
| + int parent_routing_id) { |
| + TRACE_EVENT0("browser", "WebContentsImpl::CreateRenderFrameForRenderManager"); |
| + |
| + RenderFrameHostImpl* rfh = |
| + static_cast<RenderFrameHostImpl*>(render_frame_host); |
| + if (!rfh->CreateRenderFrame(parent_routing_id)) |
| + return false; |
| + |
| + // TODO(nasko): When RenderWidgetHost is owned by RenderFrameHost, the passed |
| + // RenderFrameHost will have to be associated with the appropriate |
| + // RenderWidgetHostView or a new one should be created here. |
|
Charlie Reis
2014/07/24 22:36:30
Is this the reason we need this method to be in We
nasko
2014/07/25 07:13:21
The reason it is here is to deal with widgets and
Charlie Reis
2014/07/28 19:24:28
Acknowledged.
|
| + |
| + return true; |
| +} |
| + |
| #if defined(OS_ANDROID) |
| base::android::ScopedJavaLocalRef<jobject> |